os: winsymlink and winreadlinkvolume missing IncNonDefault calls #66215
Labels
FrozenDueToAge
NeedsFix
The path to resolution is known, but the work has not been done.
release-blocker
Milestone
The new definitions of winsymlink and winreadlinkvolume godebugs in package os are missing calls to IncNonDefault to record when they change the behavior of the program. See
go doc internal/godebug
for details.Note that to be a useful metric, IncNonDefault has to be called only when the result is actually different, not just when new code is executing that does the same thing old code would have done for a given input. That means checking the input and understanding when a deviation is happening.
This means that
is not a viable implementation strategy on its own. However, one possibility is to rename the current Mode to mode and then do
/cc @qmuntal
The text was updated successfully, but these errors were encountered: