Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestScript tests failing on platforms without telemetry support #66205

Closed
hyangah opened this issue Mar 8, 2024 · 3 comments
Closed

cmd/go: TestScript tests failing on platforms without telemetry support #66205

hyangah opened this issue Mar 8, 2024 · 3 comments
Labels
GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@hyangah
Copy link
Contributor

hyangah commented Mar 8, 2024

https://go-review.git.corp.google.com/c/go/+/568259 added a check on telemetry counter write. Since then the test fails on platforms that don't support telemetry writing.

E.g.
https://build.golang.org/log/d3d49775c3b219517e026d5f75e43aa3675e3bbd
https://build.golang.org/log/9d3fb4d6e7dca981a570148b6038520f692e4430
...

https://pkg.go.dev/golang.org/x/telemetry@v0.0.0-20240306184959-5f08a0cbff3f/internal/telemetry#pkg-constants

@golang/telemetry Can we evaluate if we can expose this platform support status through API?
@gopherbot
Copy link

Change https://go.dev/cl/570196 mentions this issue: cmd/go: check checkCounters counter read only on supported platforms

@mknyszek mknyszek added GoCommand cmd/go NeedsFix The path to resolution is known, but the work has not been done. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed NeedsFix The path to resolution is known, but the work has not been done. labels Mar 9, 2024
@mknyszek mknyszek added this to the Backlog milestone Mar 9, 2024
gopherbot pushed a commit that referenced this issue Mar 9, 2024
@hyangah
cmd/go: check checkCounters counter read only on supported platforms
065c5d2 
Telemetry counters writing is disabled on certain platforms.
See x/telemetry/internal/telemetry.DisabledOnPlatform.

For #66205

Change-Id: I833e15ae33fb27e09d67fc77b921498476237176
Reviewed-on: https://go-review.googlesource.com/c/go/+/570196
Reviewed-by: Michael Matloob <matloob@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
@kolyshkin
Copy link
Contributor

For those without corp.google.com access, this is https://go.dev/cl/568259

@matloob
Copy link
Contributor

matloob commented Mar 12, 2024

Closing this since https://golang.org/cl/570196 was submitted

@matloob matloob closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@mknyszek @kolyshkin @hyangah @gopherbot @matloob