Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: the hover popup for a struct field should describe its tag, if any #66176

Open
Splizard opened this issue Mar 7, 2024 · 2 comments
Open

x/tools/gopls: the hover popup for a struct field should describe its tag, if any #66176

Splizard opened this issue Mar 7, 2024 · 2 comments
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. help wanted Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@Splizard
Copy link

Splizard commented Mar 7, 2024 •
edited

Hovering over a field of a struct value shows the field name and field type, along with any comments attached to the field, however it doesn't show the struct tag.

Screenshot 2024-03-07 at 2 53 50 PM

The struct tag may provide important context and there should be an option to show them inside the field highlight (if not displayed by default). It's the only piece of information missing and it's not obvious why.
@adonovan adonovan transferred this issue from golang/vscode-go Mar 7, 2024
@adonovan adonovan changed the title Make the struct-tag visible when highlighting a field. x/tools/gopls: the hover popup for a struct field should describe its tag, if any Mar 7, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 7, 2024
@gopherbot gopherbot added this to the Unreleased milestone Mar 7, 2024
@adonovan adonovan added FeatureRequest gopls Issues related to the Go language server, gopls. help wanted and removed gopls Issues related to the Go language server, gopls. labels Mar 7, 2024
@findleyr
Copy link
Contributor

Thanks, I agree that this would be useful. This is a good opportunity for a starter project.
In the meantime, moving this to the backlog to be prioritized along with other feature requests.

@findleyr findleyr modified the milestones: Unreleased, gopls/backlog Mar 11, 2024
Splizard added a commit to Splizard/go-tools that referenced this issue Apr 26, 2024
@Splizard
Fixes golang/go#66176
7633d96
Splizard added a commit to Splizard/go-tools that referenced this issue Apr 26, 2024
@Splizard
Fixes golang/go#66176
d4e5828
@Splizard Splizard mentioned this issue Apr 26, 2024
Open
@gopherbot
Copy link

Change https://go.dev/cl/581836 mentions this issue: Fixes golang/go#66176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. help wanted Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
4 participants
@Splizard @adonovan @gopherbot @findleyr