Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: improve "toolchain not available" message when patch version is missing #66175

Open
adonovan opened this issue Mar 7, 2024 · 5 comments
Open

cmd/go: improve "toolchain not available" message when patch version is missing #66175

adonovan opened this issue Mar 7, 2024 · 5 comments
Assignees
@samthanawalla
Labels
BadErrorMessage Issues related compiler error messages that should be better. FixPending Issues that have a fix which has not yet been reviewed or submitted. GoCommand cmd/go
Milestone
Go1.23

Comments

@adonovan
Copy link
Member

adonovan commented Mar 7, 2024 

xtools$ GOTOOLCHAIN=go1.22 go run hello.go
go: downloading go1.22 (darwin/arm64)
go: download go1.22 for darwin/arm64: toolchain not available
xtools$ GOTOOLCHAIN=go1.22.0 go run hello.go
Hello, world.

It took me a long while to figure out that the cause of the problem was a missing patch version suffix (.0). Either the go command should pick a reasonable suffix itself, or it should report that I am expected to provide one.
@adonovan adonovan mentioned this issue Mar 7, 2024
Open
@mknyszek mknyszek added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. GoCommand cmd/go labels Mar 8, 2024
@mknyszek mknyszek added this to the Backlog milestone Mar 8, 2024
@mknyszek
Copy link
Contributor

mknyszek commented Mar 8, 2024

CC @bcmills and @matloob via https://dev.golang.org/owners

@bcmills bcmills added the BadErrorMessage Issues related compiler error messages that should be better. label Mar 11, 2024
@bcmills
Copy link
Contributor

bcmills commented Mar 11, 2024

(CC @samthanawalla)

@dmitshur dmitshur mentioned this issue Mar 20, 2024
Closed
@ldemailly
Copy link

it's worse in the case of no explicit TOOLCHAIN (if you set a toolchain I think it's reasonable that it'd be fully qualified) but completely baffling when happening indirectly through a go.mod entry that breaks all previous use of go x.y before go 1.21

See details in #62278 (comment)

@individual-it individual-it mentioned this issue Mar 26, 2024
Merged
9 tasks
@VeyronSakai VeyronSakai mentioned this issue Apr 2, 2024
Merged
elohmeier added a commit to elohmeier/nomad-hcloud-autoscaler that referenced this issue Apr 2, 2024
@elohmeier
workaround golang/go#66175
5779fe4
@matloob matloob modified the milestones: Backlog, Go1.23 Apr 2, 2024
@haruyama480
Copy link
Contributor

There are several approaches to work.

  1. Specify a patch version in go directive, like go 1.22.0.
  2. Specify a toolchain name in toolchain directive, like toolchain go1.22.0. Note that go1.22 isn't a toolchain name.
  3. Run export GOTOOLCHAIN='go1.22.0+auto' for your environments that are trying to install newer go toolchain.

The Go Version, like1.22, is called 'language version'.

Specifying language version in go directive without toolchain directive will make developers which need to download newer toolchain fail. I hope go command or any document notes that.

This was referenced Apr 3, 2024
Merged
Open
@Amulyam24 Amulyam24 mentioned this issue Apr 16, 2024
Closed
1 task
elohmeier added a commit to elohmeier/nomad-hcloud-autoscaler that referenced this issue Apr 20, 2024
@elohmeier
workaround golang/go#66175
a4e36d8
@gopherbot
Copy link

Change https://go.dev/cl/580217 mentions this issue: Require patch in GOTOOLCHAIN or download 1.X.0 otherwise.

@samthanawalla samthanawalla added FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 22, 2024
@samthanawalla samthanawalla mentioned this issue Apr 23, 2024
Closed
@bsushmith bsushmith mentioned this issue Apr 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samthanawalla samthanawalla

Labels
BadErrorMessage Issues related compiler error messages that should be better. FixPending Issues that have a fix which has not yet been reviewed or submitted. GoCommand cmd/go
Projects
None yet
Milestone
Go1.23
Development

No branches or pull requests
8 participants
@mknyszek @ldemailly @bcmills @adonovan @gopherbot @matloob @samthanawalla @haruyama480