Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/telemetry/internal/upload: TestRandom failures #66172

Closed
gopherbot opened this issue Mar 7, 2024 · 4 comments
Closed

x/telemetry/internal/upload: TestRandom failures #66172

gopherbot opened this issue Mar 7, 2024 · 4 comments
Assignees
@pjweinb
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
default <- pkg == "golang.org/x/telemetry/internal/upload" && test == "TestRandom"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestRandom (0.16s)
    first_test.go:52: cnt 147 more than 4.5 sigma(10) from mean(100)

— watchflakes
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/telemetry/internal/upload" && test == "TestRandom"
2024-03-06 21:06 linux-ppc64le-buildlet telemetry@d5a85b27 go@d44ec4c0 x/telemetry/internal/upload.TestRandom (log) 
--- FAIL: TestRandom (0.16s)
    first_test.go:52: cnt 147 more than 4.5 sigma(10) from mean(100)

— watchflakes

@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues labels Mar 7, 2024
@gopherbot gopherbot added this to the Unreleased milestone Mar 7, 2024
@findleyr
Copy link
Contributor

findleyr commented May 9, 2024

@pjweinb can we please make this test astronomically un-flaky?

@pjweinb
Copy link

pjweinb commented May 10, 2024

sure. the easiest way would be to remove it altogether. For, after months of running it it seems ok. Alternatively we can up the 4.5 to some larger number, and reduce the flake rate to expect one a century [but it might happen tomorrow and again the day after].

Either seems fine to me.

@gopherbot
Copy link
Author

Change https://go.dev/cl/584755 mentions this issue: internal/update: run TestRandom less often

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjweinb pjweinb

Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@pjweinb @gopherbot @findleyr