Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: issue title #66163

Closed
xhyqaq opened this issue Mar 7, 2024 · 1 comment
Closed

x/pkgsite: issue title #66163

xhyqaq opened this issue Mar 7, 2024 · 1 comment
Labels
pkgsite
Milestone
Unreleased

Comments

@xhyqaq
Copy link

xhyqaq commented Mar 7, 2024

What is the URL of the page with the issue?

https://github.com/golang/pkgsite/blob/master/internal/middleware/requests.go

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36 Edg/122.0.0.0

Screenshot

image

image

What did you do?

git clone

What did you see happen?

context.WithCancelCause not found

  • Troubleshooting: WithCancelCause can only be used with go version 1.2.0+

  • I'm a newbie and I don't understand why the go.mod version isn't updated here

What did you expect to see?

context.WithCancelCause No error
@xhyqaq xhyqaq added the pkgsite label Mar 7, 2024
@gopherbot gopherbot added this to the Unreleased milestone Mar 7, 2024
@Jorropo
Copy link
Member

Jorropo commented Mar 7, 2024

WithCancelClause was added in go 1.20, so go 1.19 does not have this feature.

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.

For asking questions please see: https://go.dev/wiki/Questions

@Jorropo Jorropo closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@gopherbot @Jorropo @xhyqaq