Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go 1.22.0: go test throws errors when processing folders not listed in coverpkg argument [1.22 backport] #66137

Closed
gopherbot opened this issue Mar 6, 2024 · 2 comments
Closed

cmd/go: go 1.22.0: go test throws errors when processing folders not listed in coverpkg argument [1.22 backport] #66137

gopherbot opened this issue Mar 6, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Milestone
Go1.22.2

Comments

@gopherbot
Copy link

@thanm requested issue #65653 to be considered for backport to the next 1.22 minor release.

@gopherbot please consider this for backport to 1.22
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases GoCommand cmd/go labels Mar 6, 2024
@gopherbot gopherbot mentioned this issue Mar 6, 2024
Closed
@gopherbot gopherbot added this to the Go1.22.2 milestone Mar 6, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/569575 mentions this issue: cmd/go: respect -coverpkg for unselected no-test packages

@bcmills bcmills added the CherryPickApproved Used during the release process for point releases label Mar 6, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 6, 2024
@favonia favonia mentioned this issue Mar 6, 2024
Open
@dmathieu dmathieu mentioned this issue Mar 11, 2024
Merged
@ivanvc ivanvc mentioned this issue Mar 11, 2024
Closed
4 tasks
gopherbot pushed a commit that referenced this issue Mar 21, 2024
@thanm
[release-branch.go1.22] cmd/go: respect -coverpkg for unselected no-t…
35b1a14 
…est packages

This patch fixes a bug in the code that reports coverage percentages
and/or profiles for packages without tests. Specifically, the code
added as part of the fix for issue 24570 (in CL 495447) didn't
properly consider the -coverpkg selection and would look for the build
action meta-data file for a package that wasn't actually selected for
coverage.

Updates #65653.
Fixes #66137.

Change-Id: I66ffac11783c00a8cbd855fd05b9a90e4e0ed402
Reviewed-on: https://go-review.googlesource.com/c/go/+/568835
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 2b22fc1)
Reviewed-on: https://go-review.googlesource.com/c/go/+/569575
@gopherbot
Copy link
Author

Closed by merging 35b1a14 to release-branch.go1.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases GoCommand cmd/go
Projects
None yet
Milestone
Go1.22.2
Development

No branches or pull requests
2 participants
@bcmills @gopherbot