-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: go test . results in CLOSURE ... <unknown line number>: internal compiler error: assertion failed [1.22 backport] #66134
Labels
CherryPickApproved
Used during the release process for point releases
Milestone
Comments
gopherbot
added
the
CherryPickCandidate
Used during the release process for point releases
label
Mar 6, 2024
mknyszek
changed the title
cmd/go: go test . results in CLOSURE ... <unknown line number>: internal compiler error: assertion failed [1.22 backport]
cmd/compile: go test . results in CLOSURE ... <unknown line number>: internal compiler error: assertion failed [1.22 backport]
Mar 6, 2024
The fix is small and safe and avoids an internal compiler error which is a serious issue. Approved for backport. |
mknyszek
added
the
CherryPickApproved
Used during the release process for point releases
label
Mar 6, 2024
gopherbot
removed
the
CherryPickCandidate
Used during the release process for point releases
label
Mar 6, 2024
Change https://go.dev/cl/569717 mentions this issue: |
gopherbot
pushed a commit
that referenced
this issue
Mar 26, 2024
…atement CL 517775 moved early deadcode into unified writer. with new way to handle dead code with label statement involved: any statements after terminating statement will be considered dead until next label statement. However, this is not safe, because code after label statement may still refer to dead statements between terminating and label statement. It's only safe to remove statements after terminating *and* label one. Fixes #66134 Change-Id: Idb630165240931fad50789304a9e4535f51f56e2 Reviewed-on: https://go-review.googlesource.com/c/go/+/565596 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Matthew Dempsky <mdempsky@google.com> Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com> Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com> Reviewed-on: https://go-review.googlesource.com/c/go/+/569717 Reviewed-by: Michael Knyszek <mknyszek@google.com>
Closed by merging 3826650 to release-branch.go1.22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@randall77 requested issue #65593 to be considered for backport to the next 1.22 minor release.
The text was updated successfully, but these errors were encountered: