Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: go test . results in CLOSURE ... <unknown line number>: internal compiler error: assertion failed [1.22 backport] #66134

Closed
gopherbot opened this issue Mar 6, 2024 · 3 comments
Closed

cmd/compile: go test . results in CLOSURE ... <unknown line number>: internal compiler error: assertion failed [1.22 backport] #66134

gopherbot opened this issue Mar 6, 2024 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases
Milestone
Go1.22.2

Comments

@gopherbot
Copy link

@randall77 requested issue #65593 to be considered for backport to the next 1.22 minor release.

@gopherbot Please open a backport issue for 1.22.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Mar 6, 2024
@gopherbot gopherbot mentioned this issue Mar 6, 2024
Closed
@gopherbot gopherbot added this to the Go1.22.2 milestone Mar 6, 2024
@mknyszek mknyszek added GoCommand cmd/go and removed GoCommand cmd/go labels Mar 6, 2024
@mknyszek mknyszek changed the title cmd/go: go test . results in CLOSURE ... <unknown line number>: internal compiler error: assertion failed [1.22 backport] cmd/compile: go test . results in CLOSURE ... <unknown line number>: internal compiler error: assertion failed [1.22 backport] Mar 6, 2024
@mknyszek
Copy link
Contributor

mknyszek commented Mar 6, 2024

The fix is small and safe and avoids an internal compiler error which is a serious issue. Approved for backport.

@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Mar 6, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 6, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/569717 mentions this issue: [release-branch.go1.22] cmd/compile: fix early deadcode with label statement

gopherbot pushed a commit that referenced this issue Mar 26, 2024
@cuonglm @thanm
[release-branch.go1.22] cmd/compile: fix early deadcode with label st…
3826650 
…atement

CL 517775 moved early deadcode into unified writer. with new way to
handle dead code with label statement involved: any statements after
terminating statement will be considered dead until next label
statement.

However, this is not safe, because code after label statement may still
refer to dead statements between terminating and label statement.

It's only safe to remove statements after terminating *and* label one.

Fixes #66134

Change-Id: Idb630165240931fad50789304a9e4535f51f56e2
Reviewed-on: https://go-review.googlesource.com/c/go/+/565596
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Auto-Submit: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/569717
Reviewed-by: Michael Knyszek <mknyszek@google.com>
@gopherbot
Copy link
Author

Closed by merging 3826650 to release-branch.go1.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases
Projects
None yet
Milestone
Go1.22.2
Development

No branches or pull requests
2 participants
@mknyszek @gopherbot