Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/integration/template: TestModFileModification failures #66104

Closed
gopherbot opened this issue Mar 4, 2024 · 2 comments
Closed

x/tools/gopls/internal/test/integration/template: TestModFileModification failures #66104

gopherbot opened this issue Mar 4, 2024 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/template" && test == "TestModFileModification"

Issue created automatically to collect these failures.

Example (log):

goroutine profile: total 7
1 @ 0xf46991 0xf8237d 0x110ebf1 0x110ea25 0x110b84b 0x194b7b0 0x194b334 0x105f41b 0xf89441
#	0xf8237c	runtime/pprof.runtime_goroutineProfileWithLabels+0x1c				C:/workdir/go/src/runtime/mprof.go:1079
#	0x110ebf0	runtime/pprof.writeRuntimeProfile+0xb0						C:/workdir/go/src/runtime/pprof/pprof.go:775
#	0x110ea24	runtime/pprof.writeGoroutine+0x44						C:/workdir/go/src/runtime/pprof/pprof.go:734
#	0x110b84a	runtime/pprof.(*Profile).WriteTo+0x14a						C:/workdir/go/src/runtime/pprof/pprof.go:369
#	0x194b7af	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:207
#	0x194b333	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xc93	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:255
#	0x105f41a	testing.tRunner+0xfa								C:/workdir/go/src/testing/testing.go:1689

...

1 @ 0xf530ae 0xf85bba 0x16df36a 0xf89441
#	0xf85bb9	time.Sleep+0x119					C:/workdir/go/src/runtime/time.go:214
#	0x16df369	golang.org/x/tools/gopls/internal/filecache.gc+0x249	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/filecache/filecache.go:507

--- FAIL: TestModFileModification (66.03s)
    --- FAIL: TestModFileModification/basic (44.15s)
        --- FAIL: TestModFileModification/basic/default (32.84s)
            --- FAIL: TestModFileModification/basic/default/default (14.54s)
                runner.go:208: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: remove C:\Users\gopher\AppData\Local\Temp\1\gopls-test-277782551\TestModFileModification\basic\default\default\work: The process cannot access the file because it is being used by another process.

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 4, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/template" && test == "TestModFileModification"
2024-02-29 21:45 windows-amd64-longtest tools@5bf7d005 go@b09ac10b x/tools/gopls/internal/test/integration/template.TestModFileModification (log) 
goroutine profile: total 7
1 @ 0xf46991 0xf8237d 0x110ebf1 0x110ea25 0x110b84b 0x194b7b0 0x194b334 0x105f41b 0xf89441
#	0xf8237c	runtime/pprof.runtime_goroutineProfileWithLabels+0x1c				C:/workdir/go/src/runtime/mprof.go:1079
#	0x110ebf0	runtime/pprof.writeRuntimeProfile+0xb0						C:/workdir/go/src/runtime/pprof/pprof.go:775
#	0x110ea24	runtime/pprof.writeGoroutine+0x44						C:/workdir/go/src/runtime/pprof/pprof.go:734
#	0x110b84a	runtime/pprof.(*Profile).WriteTo+0x14a						C:/workdir/go/src/runtime/pprof/pprof.go:369
#	0x194b7af	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:207
#	0x194b333	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xc93	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:255
#	0x105f41a	testing.tRunner+0xfa								C:/workdir/go/src/testing/testing.go:1689

...

1 @ 0xf530ae 0xf85bba 0x16df36a 0xf89441
#	0xf85bb9	time.Sleep+0x119					C:/workdir/go/src/runtime/time.go:214
#	0x16df369	golang.org/x/tools/gopls/internal/filecache.gc+0x249	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/filecache/filecache.go:507

--- FAIL: TestModFileModification (66.03s)
    --- FAIL: TestModFileModification/basic (44.15s)
        --- FAIL: TestModFileModification/basic/default (32.84s)
            --- FAIL: TestModFileModification/basic/default/default (14.54s)
                runner.go:208: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: remove C:\Users\gopher\AppData\Local\Temp\1\gopls-test-277782551\TestModFileModification\basic\default\default\work: The process cannot access the file because it is being used by another process.

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 4, 2024
@gopherbot gopherbot added this to the Unreleased milestone Mar 4, 2024
@bcmills
Copy link
Contributor

bcmills commented Mar 4, 2024

Duplicate of #66099

@bcmills bcmills marked this as a duplicate of #66099 Mar 4, 2024
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot