Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/integration/inlayhints: TestDisablingCodeLens failures #66103

Closed
gopherbot opened this issue Mar 4, 2024 · 2 comments
Closed

x/tools/gopls/internal/test/integration/inlayhints: TestDisablingCodeLens failures #66103

gopherbot opened this issue Mar 4, 2024 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/inlayhints" && test == "TestDisablingCodeLens"

Issue created automatically to collect these failures.

Example (log):

goroutine profile: total 8
1 @ 0xca6991 0xce237d 0xe6eb51 0xe6e985 0xe6b7ab 0x16aa3f0 0x16a9f74 0xdbf37b 0xce9441
#	0xce237c	runtime/pprof.runtime_goroutineProfileWithLabels+0x1c				C:/workdir/go/src/runtime/mprof.go:1079
#	0xe6eb50	runtime/pprof.writeRuntimeProfile+0xb0						C:/workdir/go/src/runtime/pprof/pprof.go:775
#	0xe6e984	runtime/pprof.writeGoroutine+0x44						C:/workdir/go/src/runtime/pprof/pprof.go:734
#	0xe6b7aa	runtime/pprof.(*Profile).WriteTo+0x14a						C:/workdir/go/src/runtime/pprof/pprof.go:369
#	0x16aa3ef	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:207
#	0x16a9f73	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xc93	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:255
#	0xdbf37a	testing.tRunner+0xfa								C:/workdir/go/src/testing/testing.go:1689

...

1 @ 0xcb30ae 0xce5bba 0x140542a 0xce9441
#	0xce5bb9	time.Sleep+0x119					C:/workdir/go/src/runtime/time.go:214
#	0x1405429	golang.org/x/tools/gopls/internal/filecache.gc+0x249	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/filecache/filecache.go:507

--- FAIL: TestDisablingCodeLens (29.41s)
    --- FAIL: TestDisablingCodeLens/generate_disabled (16.18s)
        --- FAIL: TestDisablingCodeLens/generate_disabled/default (8.27s)
            runner.go:208: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: remove C:\Users\gopher\AppData\Local\Temp\1\gopls-test-1722857689\TestDisablingCodeLens\generate_disabled\default\work: The process cannot access the file because it is being used by another process.
2024/03/04 20:34:15 error killing the Go command: TerminateProcess: Access is denied.

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 4, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/inlayhints" && test == "TestDisablingCodeLens"
2024-02-29 21:45 windows-amd64-longtest tools@5bf7d005 go@2b22fc10 x/tools/gopls/internal/test/integration/inlayhints.TestDisablingCodeLens (log) 
goroutine profile: total 8
1 @ 0xca6991 0xce237d 0xe6eb51 0xe6e985 0xe6b7ab 0x16aa3f0 0x16a9f74 0xdbf37b 0xce9441
#	0xce237c	runtime/pprof.runtime_goroutineProfileWithLabels+0x1c				C:/workdir/go/src/runtime/mprof.go:1079
#	0xe6eb50	runtime/pprof.writeRuntimeProfile+0xb0						C:/workdir/go/src/runtime/pprof/pprof.go:775
#	0xe6e984	runtime/pprof.writeGoroutine+0x44						C:/workdir/go/src/runtime/pprof/pprof.go:734
#	0xe6b7aa	runtime/pprof.(*Profile).WriteTo+0x14a						C:/workdir/go/src/runtime/pprof/pprof.go:369
#	0x16aa3ef	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:207
#	0x16a9f73	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xc93	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:255
#	0xdbf37a	testing.tRunner+0xfa								C:/workdir/go/src/testing/testing.go:1689

...

1 @ 0xcb30ae 0xce5bba 0x140542a 0xce9441
#	0xce5bb9	time.Sleep+0x119					C:/workdir/go/src/runtime/time.go:214
#	0x1405429	golang.org/x/tools/gopls/internal/filecache.gc+0x249	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/filecache/filecache.go:507

--- FAIL: TestDisablingCodeLens (29.41s)
    --- FAIL: TestDisablingCodeLens/generate_disabled (16.18s)
        --- FAIL: TestDisablingCodeLens/generate_disabled/default (8.27s)
            runner.go:208: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: remove C:\Users\gopher\AppData\Local\Temp\1\gopls-test-1722857689\TestDisablingCodeLens\generate_disabled\default\work: The process cannot access the file because it is being used by another process.
2024/03/04 20:34:15 error killing the Go command: TerminateProcess: Access is denied.

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Mar 4, 2024
@gopherbot gopherbot added this to the Unreleased milestone Mar 4, 2024
@bcmills
Copy link
Contributor

bcmills commented Mar 4, 2024

Duplicate of #66099

@bcmills bcmills marked this as a duplicate of #66099 Mar 4, 2024
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
@bcmills bcmills removed this from Test Flakes Mar 4, 2024
@golang golang locked and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot