Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gerritbot: creates broken hyperlinks ("publish your drafts!") #65998

Closed
guettli opened this issue Feb 28, 2024 · 2 comments
Closed

x/build/cmd/gerritbot: creates broken hyperlinks ("publish your drafts!") #65998

guettli opened this issue Feb 28, 2024 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@guettli
Copy link

guettli commented Feb 28, 2024

Go version

does not apply

Output of go env in your module/workspace:

does not apply

What did you do?

I created a tiny PR for Go, and a message created by gopherbot contains a broken hyperlink.

What did you see happen?

The message: #65218 (comment)

Link to publish your drafts is broken.

What did you expect to see?

I expect to see a hyperlink to the docs about how to "publish your drafts"
@dmitshur dmitshur changed the title gopherbot creates broken hyperlinks ("publish your drafts!") x/build/cmd/gerritbot: creates broken hyperlinks ("publish your drafts!") Feb 28, 2024
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 28, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 28, 2024
@dmitshur
Copy link
Contributor

dmitshur commented Feb 28, 2024 •
edited

Thanks for reporting.

Fixing this will involve navigating the constraint that the current message is used for de-duplication, so changes to its exact text without an additional mechanism to detect comments that have been synchronized will lead to duplicates. See CL 530736 for details.

It is more important to fix this now as the github.com/golang/go/wiki link is no longer equivalent and simply broken, as you pointed out.

CC @golang/release, @thepudds.

@dmitshur dmitshur added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 28, 2024
@gopherbot
Copy link

Change https://go.dev/cl/568055 mentions this issue: cmd/gerritbot: link to go.dev/wiki instead of GitHub wiki

@dmitshur dmitshur added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@guettli @dmitshur @gopherbot