Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/hooks: TestLicenses failures #65978

Closed
gopherbot opened this issue Feb 27, 2024 · 2 comments
Closed

x/tools/gopls/internal/hooks: TestLicenses failures #65978

gopherbot opened this issue Feb 27, 2024 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.0

Comments

@gopherbot
Copy link 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/hooks" && test == "TestLicenses"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestLicenses
    licenses_test.go:33: generating licenses failed: "./gen-licenses.sh: line 26: sort: command not found\n", exit status 1
--- FAIL: TestLicenses (0.15s)

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 27, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 27, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/hooks" && test == "TestLicenses"
2024-02-26 20:52 x_tools-go1.21-darwin-amd64_12 tools@97c51a2b release-branch.go1.21@f38fca30 x/tools/gopls/internal/hooks.TestLicenses (log) 
=== RUN   TestLicenses
    licenses_test.go:33: generating licenses failed: "./gen-licenses.sh: line 26: sort: command not found\n", exit status 1
--- FAIL: TestLicenses (0.15s)

— watchflakes

@suzmue suzmue modified the milestones: Unreleased, gopls/v0.16.0 Feb 28, 2024
@suzmue
Copy link
Contributor

suzmue commented Feb 29, 2024

This looks like a problem with the builder. Since it went away, we won't investigate further for now.

@suzmue suzmue closed this as completed Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
gopls/v0.16.0
Development

No branches or pull requests
2 participants
@suzmue @gopherbot