Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: redundant diagnostics due to quick fixes #65966

Open
findleyr opened this issue Feb 27, 2024 · 0 comments
Open

x/tools/gopls: redundant diagnostics due to quick fixes #65966

findleyr opened this issue Feb 27, 2024 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

The following code causes three "too many returns" diagnostics in gopls. Notably, the present but empty result list is required, so this is probably a low priority bug.

func _() () {
  return 0
}

It looks like somehow the "fillreturns" and "noresultvalues" analyzers are colliding, and causing duplication. This may manifest in other ways as we add more quick fixes.

@findleyr findleyr added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Refactoring Issues related to refactoring tools labels Feb 27, 2024
@findleyr findleyr added this to the gopls/v0.16.0 milestone Feb 27, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Refactoring Issues related to refactoring tools Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants