Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/telemetry/cmd/stacks: allow dups to be reported by simply appending a comment #65963

Open
adonovan opened this issue Feb 27, 2024 · 0 comments
Labels
gopls/telemetry issues that would benefit from telemetry data gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@adonovan
Copy link
Member

The stacks command de-dups stack counter reports based on their hash. A GitHub issue search looks for this hash in the first comment attached to an issue ("in:body"). So, when triaging reports one must edit the first comment and append the new stack.

It would be more convenient (and easier to see the timeline) if we could simply copy the stack into a new comment, but this won't show up in the issues search. We could remove the in:body restriction, but extra work is required to fetch all the comment bodies for an issue: in principle there may be hundreds, so only the first is returned "for free".

Alternatively we could just stick with having to modify the first comment.

@adonovan adonovan added the gopls/telemetry issues that would benefit from telemetry data label Feb 27, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 27, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls/telemetry issues that would benefit from telemetry data gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants