Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: loop inversion does not support unsigned numbers #65918

Open
Jorropo opened this issue Feb 24, 2024 · 1 comment
Open

cmd/compile: loop inversion does not support unsigned numbers #65918

Jorropo opened this issue Feb 24, 2024 · 1 comment
Assignees
@Jorropo
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Performance
Milestone
Backlog

Comments

@Jorropo
Copy link
Member

Jorropo commented Feb 24, 2024

This is duplicate of #61629 but for:

for range uint(x) {
 // ...
}

I didn't implemented it back then since I reused existing scanning code (findIndVar) which only supported signed ops:

go/src/cmd/compile/internal/ssa/loopbce.go

Line 99 in ef84d62

// TODO: Handle unsigned comparisons?

I'll submit a patch.
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 24, 2024
@Jorropo Jorropo added this to the Backlog milestone Feb 24, 2024
@gopherbot
Copy link

Change https://go.dev/cl/566437 mentions this issue: cmd/compile: add very basic unsigned matching to findIndVar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jorropo Jorropo

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. Performance
Projects
Go Compiler / Runtime
Status: Todo
Milestone
Backlog
Development

No branches or pull requests
2 participants
@gopherbot @Jorropo