Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: unreachable panic with GODEBUG=gotypesalias=1 [1.22 backport] #65858

Closed
gopherbot opened this issue Feb 21, 2024 · 3 comments
Closed

cmd/compile: unreachable panic with GODEBUG=gotypesalias=1 [1.22 backport] #65858

gopherbot opened this issue Feb 21, 2024 · 3 comments
Assignees
@griesemer
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.22.2

Comments

@gopherbot
Copy link

@findleyr requested issue #65778 to be considered for backport to the next 1.22 minor release.

@gopherbot please consider this for backport to 1.22. It is a panic that prevents tool developers from preparing their tool for go/types Aliases.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 21, 2024
@gopherbot gopherbot mentioned this issue Feb 21, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 21, 2024
@gopherbot gopherbot added this to the Go1.22.1 milestone Feb 21, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/565840 mentions this issue: [release-branch.go1.22] go/types, types2: handle Alias types in substitution

@griesemer griesemer self-assigned this Feb 22, 2024
@gopherbot gopherbot modified the milestones: Go1.22.1, Go1.22.2 Mar 5, 2024
@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Mar 6, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Mar 6, 2024
@mknyszek
Copy link
Contributor

mknyszek commented Mar 6, 2024

Approved because it's a serious issue affecting tool developers. It's also safe because it's behind a GODEBUG flag, so most users won't run into any new issues introduced.

@gopherbot
Copy link
Author

Closed by merging e23707b to release-branch.go1.22.

gopherbot pushed a commit that referenced this issue Mar 26, 2024
@griesemer @thanm
[release-branch.go1.22] go/types, types2: handle Alias types in subst…
e23707b 
…itution

Fixes #65858.
For #65778. // for x/tools/cmd/gotype

Change-Id: I67d4644b28e831926fc6c233098aa1755c57162f
Reviewed-on: https://go-review.googlesource.com/c/go/+/565835
Auto-Submit: Robert Griesemer <gri@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Robert Griesemer <gri@google.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/565840
Run-TryBot: Robert Griesemer <gri@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@griesemer griesemer

Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.22.2
Development

No branches or pull requests
3 participants
@mknyszek @griesemer @gopherbot