Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/mail: comments in display names are incorrectly handled [1.22 backport] #65849

Closed
gopherbot opened this issue Feb 21, 2024 · 2 comments
Closed

net/mail: comments in display names are incorrectly handled [1.22 backport] #65849

gopherbot opened this issue Feb 21, 2024 · 2 comments
Assignees
@neild
Labels
CherryPickApproved Used during the release process for point releases Security
Milestone
Go1.22.1

Comments

@gopherbot
Copy link

@neild requested issue #65083 to be considered for backport to the next 1.22 minor release.

@gopherbot please open backport issues, this is a PUBLIC track security fix
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases Security labels Feb 21, 2024
@gopherbot gopherbot mentioned this issue Feb 21, 2024
Closed
@gopherbot gopherbot added this to the Go1.22.1 milestone Feb 21, 2024
@neild neild self-assigned this Feb 21, 2024
@neild neild added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Feb 21, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/566215 mentions this issue: [release-branch.go1.22] net/mail: properly handle special characters in phrase and obs-phrase

gopherbot pushed a commit that referenced this issue Feb 28, 2024
@rolandshoemaker @cagedmantis
[release-branch.go1.22] net/mail: properly handle special characters …
5330cd2 
…in phrase and obs-phrase

Fixes a couple of misalignments with RFC 5322 which introduce
significant diffs between (mostly) conformant parsers.

This change reverts the changes made in CL50911, which allowed certain
special RFC 5322 characters to appear unquoted in the "phrase" syntax.
It is unclear why this change was made in the first place, and created
a divergence from comformant parsers. In particular this resulted in
treating comments in display names incorrectly.

Additionally properly handle trailing malformed comments in the group
syntax.

For #65083
Fixed #65849

Change-Id: I00dddc044c6ae3381154e43236632604c390f672
Reviewed-on: https://go-review.googlesource.com/c/go/+/555596
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/566215
Reviewed-by: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link
Author

Closed by merging 5330cd2 to release-branch.go1.22.

bradfitz pushed a commit to tailscale/go that referenced this issue Mar 5, 2024
@rolandshoemaker @bradfitz
[release-branch.go1.22] net/mail: properly handle special characters …
5c01bab 
…in phrase and obs-phrase

Fixes a couple of misalignments with RFC 5322 which introduce
significant diffs between (mostly) conformant parsers.

This change reverts the changes made in CL50911, which allowed certain
special RFC 5322 characters to appear unquoted in the "phrase" syntax.
It is unclear why this change was made in the first place, and created
a divergence from comformant parsers. In particular this resulted in
treating comments in display names incorrectly.

Additionally properly handle trailing malformed comments in the group
syntax.

For golang#65083
Fixed golang#65849

Change-Id: I00dddc044c6ae3381154e43236632604c390f672
Reviewed-on: https://go-review.googlesource.com/c/go/+/555596
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/566215
Reviewed-by: Carlos Amedee <carlos@golang.org>
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 6, 2024
@rolandshoemaker @romaindoumenc
[release-branch.go1.22] net/mail: properly handle special characters …
ee82336 
…in phrase and obs-phrase

Fixes a couple of misalignments with RFC 5322 which introduce
significant diffs between (mostly) conformant parsers.

This change reverts the changes made in CL50911, which allowed certain
special RFC 5322 characters to appear unquoted in the "phrase" syntax.
It is unclear why this change was made in the first place, and created
a divergence from comformant parsers. In particular this resulted in
treating comments in display names incorrectly.

Additionally properly handle trailing malformed comments in the group
syntax.

For golang#65083
Fixed golang#65849

Change-Id: I00dddc044c6ae3381154e43236632604c390f672
Reviewed-on: https://go-review.googlesource.com/c/go/+/555596
Reviewed-by: Damien Neil <dneil@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-on: https://go-review.googlesource.com/c/go/+/566215
Reviewed-by: Carlos Amedee <carlos@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neild neild

Labels
CherryPickApproved Used during the release process for point releases Security
Projects
None yet
Milestone
Go1.22.1
Development

No branches or pull requests
2 participants
@neild @gopherbot