x/build: timeout_scale parameter not applied on LUCI builders for x/ repos #65845
Assignees
Labels
Builders
x/build issues (builders, bots, dashboards)
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Comments
|
It appears that the actual So I guess that's where the |
dmitshur
added
the
NeedsInvestigation
|
Change https://go.dev/cl/565697 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Feb 21, 2024
This change sets the test_timeout_scale property instead of setting GO_TEST_TIMEOUT_SCALE directly. This property ensures the timeout scale propagates to all testing contexts, including `go test`, in golangbuild. This change also allows run mods to influence the test timeout scale of subrepo builders, since that was previously not explicitly handled, but led to flaky test timeouts on subrepo builds. Depends on https://crrev.com/c/5314204. This CL must wait until that change lands and rolls out. Fixes golang/go#65845. Change-Id: I3d38922d64fa225da233206bf53994d4b85843c7 Reviewed-on: https://go-review.googlesource.com/c/build/+/565697 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Bypass: Michael Knyszek <mknyszek@google.com>
|
I believe this is now resolved. I verified on an x/tools longtest build that the |
This was referenced Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Go version
86a32d6
Output of
go envin your module/workspace:What did you do?
Read #65820 (comment).
What did you see happen?
The logs linked from https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-darwin-amd64-longtest/b8755859092256698353/overview appear to show
go testcommands run without setting the-timeoutflag.It appears that the LUCI configuration only uses the
timeout_scaleparameter to set theGO_TEST_TIMEOUT_SCALEenvironment variable, which is intended to be specific tocmd/distand should have little to no effect on other commands.(https://cs.opensource.google/go/x/build/+/luci-config:main.star;l=1206-1208;drc=c0163da662349fff6c2f585cebd08bbd836b8470)
What did you expect to see?
A
-timeoutflag set according to thetimeout_scaleparameter of the builder, analogous to what happens on the legacy builders:https://cs.opensource.google/go/x/build/+/master:cmd/coordinator/buildstatus.go;l=1187-1190;drc=498808697e0db626ec196a9a5290f5f121fa056a (issue #56968)
The text was updated successfully, but these errors were encountered: