Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash/maphash: TestSmhasher* failures on 386 #65823

Closed
gopherbot opened this issue Feb 20, 2024 · 5 comments
Closed

hash/maphash: TestSmhasher* failures on 386 #65823

gopherbot opened this issue Feb 20, 2024 · 5 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link

gopherbot commented Feb 20, 2024

#!watchflakes
default <- pkg == "hash/maphash" && test ~ `TestSmhasher.*` && goarch == "386"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestSmhasherPermutation
=== PAUSE TestSmhasherPermutation
=== CONT  TestSmhasherPermutation

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 20, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "hash/maphash" && test == "TestSmhasherPermutation"
2024-02-20 14:56 gotip-linux-386-longtest go@0a046418 hash/maphash.TestSmhasherPermutation [ABORT] (log)
=== RUN   TestSmhasherPermutation
=== PAUSE TestSmhasherPermutation
=== CONT  TestSmhasherPermutation
2024-02-20 14:59 gotip-linux-386-longtest go@ff0b46cf hash/maphash.TestSmhasherPermutation [ABORT] (log)
=== RUN   TestSmhasherPermutation
=== PAUSE TestSmhasherPermutation
=== CONT  TestSmhasherPermutation

watchflakes

@prattmic
Copy link
Member

This seems to be specific to 386, and general to all TestSmhasher tests. Adjusting the matcher.

@prattmic prattmic changed the title hash/maphash: TestSmhasherPermutation failures hash/maphash: TestSmhasher* failures on 386 Feb 20, 2024
@prattmic
Copy link
Member

The first failure was on https://go.dev/cl/564576, which seems like a likely cause.

Note that the runtime equivalent of these tests is skipped on 32-bit systems after #43130. But the symptom is different. That one had hash collisions, this one has no log output at all. My best guess is that it is OOM-killed.

cc @qiulaidongfeng @randall77

@gopherbot
Copy link
Author

Change https://go.dev/cl/565536 mentions this issue: Revert "hash/maphash: parallel run test"

@gopherbot
Copy link
Author

Sorry, but there were parse errors in the watch flakes script.
The script I found was:

#!watchflakes
default <- pkg == "hash/maphash" && test ~ "TestSmhasher.*" && goos == "386"

And the problems were:

script:2.44: ~ requires backquoted regexp

See https://go.dev/wiki/Watchflakes for details.

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: Done
Development

No branches or pull requests

2 participants