Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: TestReadMetricsCumulative failures in mayMoreStackPreempt mode #65821

Open
gopherbot opened this issue Feb 20, 2024 · 2 comments
Open

runtime: TestReadMetricsCumulative failures in mayMoreStackPreempt mode #65821

gopherbot opened this issue Feb 20, 2024 · 2 comments
Assignees
@mknyszek
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@gopherbot
Copy link 

#!watchflakes
default <- pkg == "runtime:mayMoreStackPreempt" && test == "TestReadMetricsCumulative"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestReadMetricsCumulative
    metrics_test.go:543: /cpu/classes/user:cpu-seconds decreased: 43.052189 < 43.056638
--- FAIL: TestReadMetricsCumulative (0.01s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 20, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "runtime:mayMoreStackPreempt" && test == "TestReadMetricsCumulative"
2024-02-16 20:25 gotip-windows-amd64-longtest go@cdd0ddaf runtime:mayMoreStackPreempt.TestReadMetricsCumulative (log) 
=== RUN   TestReadMetricsCumulative
    metrics_test.go:543: /cpu/classes/user:cpu-seconds decreased: 43.052189 < 43.056638
--- FAIL: TestReadMetricsCumulative (0.01s)

— watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 20, 2024
@cherrymui cherrymui changed the title runtime:mayMoreStackPreempt: TestReadMetricsCumulative failures runtime: TestReadMetricsCumulative failures in mayMoreStackPreempt mode Feb 20, 2024
@mknyszek
Copy link
Contributor

The fact that this only happened in mayMoreStack mode suggests this is a test-only issue that won't be encountered by users. I'll take a look.

@mknyszek mknyszek added this to the Backlog milestone Feb 28, 2024
@mknyszek mknyszek self-assigned this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mknyszek mknyszek

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Compiler / Runtime
Status: Todo
Test Flakes
Status: No status
Milestone
Backlog
Development

No branches or pull requests
2 participants
@mknyszek @gopherbot