Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: test timeouts on darwin longtest builder #65820

Closed
gopherbot opened this issue Feb 20, 2024 · 7 comments
Closed

x/tools/gopls: test timeouts on darwin longtest builder #65820

gopherbot opened this issue Feb 20, 2024 · 7 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.0

Comments

@gopherbot
Copy link

gopherbot commented Feb 20, 2024 •
edited by bcmills 

#!watchflakes
default <- builder == "x_tools-gotip-darwin-amd64-longtest" && date < "2024-02-22"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestPostfixSnippetCompletion/forwarded/string_slice_join
    testing.go:1576: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test
--- FAIL: TestPostfixSnippetCompletion/forwarded/string_slice_join (1.96s)
#### Start Gopls Test Logs for "TestPostfixSnippetCompletion/forwarded"
[Trace - 02:25:59.234 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"0s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/Users/swarming/.swarming/w/ir/x/t/gopls-test-2215923589/TestPostfixSnippetCompletion/forwarded/gopath","GOPROXY":"file:///Users/swarming/.swarming/w/ir/x/t/gopls-test-2215923589/TestPostfixSnippetCompletion/forwarded/proxy","GOSUMDB":"off"},"experimentalPostfixCompletions":true,"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///Users/swarming/.swarming/w/ir/x/t/gopls-test-2215923589/TestPostfixSnippetCompletion/forwarded/work","name":"work"}]}


[Trace - 02:25:59.236 AM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2024/02/17 02:25:59 Handshake session update\n\tupdate_session=89\n\tdebug_address=\"\"\n\tlogfile=\"\"\n\tserver=\"30\"\n\tgopls_path=\"/Users/swarming/.swarming/w/ir/x/t/go-build782734547/b591/completion.test\"\n"}
...

[Trace - 02:26:18.514 AM] Received notification '$/progress'.
Params: {"token":"5007001450629832726","value":{"kind":"end","message":"Done."}}


[Trace - 02:26:19.938 AM] Sending notification '$/cancelRequest'.
Params: {"id":20}


#### End Gopls Test Logs for "TestPostfixSnippetCompletion/forwarded"

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 20, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/completion" && test == "TestPostfixSnippetCompletion/forwarded/string_slice_join"
2024-02-16 15:54 x_tools-gotip-darwin-amd64-longtest tools@0d171942 go@86a32d6d x/tools/gopls/internal/test/integration/completion.TestPostfixSnippetCompletion/forwarded/string_slice_join (log) 
=== RUN   TestPostfixSnippetCompletion/forwarded/string_slice_join
    testing.go:1576: test executed panic(nil) or runtime.Goexit: subtest may have called FailNow on a parent test
--- FAIL: TestPostfixSnippetCompletion/forwarded/string_slice_join (1.96s)
#### Start Gopls Test Logs for "TestPostfixSnippetCompletion/forwarded"
[Trace - 02:25:59.234 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"0s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/Users/swarming/.swarming/w/ir/x/t/gopls-test-2215923589/TestPostfixSnippetCompletion/forwarded/gopath","GOPROXY":"file:///Users/swarming/.swarming/w/ir/x/t/gopls-test-2215923589/TestPostfixSnippetCompletion/forwarded/proxy","GOSUMDB":"off"},"experimentalPostfixCompletions":true,"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///Users/swarming/.swarming/w/ir/x/t/gopls-test-2215923589/TestPostfixSnippetCompletion/forwarded/work","name":"work"}]}


[Trace - 02:25:59.236 AM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2024/02/17 02:25:59 Handshake session update\n\tupdate_session=89\n\tdebug_address=\"\"\n\tlogfile=\"\"\n\tserver=\"30\"\n\tgopls_path=\"/Users/swarming/.swarming/w/ir/x/t/go-build782734547/b591/completion.test\"\n"}
...

[Trace - 02:26:18.514 AM] Received notification '$/progress'.
Params: {"token":"5007001450629832726","value":{"kind":"end","message":"Done."}}


[Trace - 02:26:19.938 AM] Sending notification '$/cancelRequest'.
Params: {"id":20}


#### End Gopls Test Logs for "TestPostfixSnippetCompletion/forwarded"

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 20, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 20, 2024
@findleyr
Copy link
Contributor

CC @mknyszek @prattmic @bcmills it looks like the longtest builder above is not actually setting -timeout, as opposed to the legacy longtest builders which set -timeout=1h40m0s. An oversight?

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.16.0 Feb 21, 2024
@bcmills
Copy link
Contributor

bcmills commented Feb 21, 2024

Filed the missing -timeout flag as:

@findleyr findleyr changed the title x/tools/gopls/internal/test/integration/completion: TestPostfixSnippetCompletion/forwarded/string_slice_join failures x/tools/gopls: test timeouts on darwin longtest builder Feb 21, 2024
@findleyr
Copy link
Contributor

Thanks. Edited the watchflakes stanza to match this builder.

@bcmills bcmills mentioned this issue Feb 21, 2024
Closed
@findleyr
Copy link
Contributor

Closing as the root cause (https://go.dev/issue/65845) should be fixed.

@bcmills
Copy link
Contributor

bcmills commented Feb 21, 2024

I've also updated the watchflakes pattern with a date (to avoid spurious reopening, working around #57632).

@findleyr
Copy link
Contributor

I've also updated the watchflakes pattern with a date (to avoid spurious reopening, working around #57632).

Hmm, won't that pattern still result in spurious reopening, since failures will continue to match this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
gopls/v0.16.0
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @findleyr