Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: split illumos out of solaris on TCP keep-alive mechanism #65812

Closed
panjf2000 opened this issue Feb 20, 2024 · 2 comments
Closed

net: split illumos out of solaris on TCP keep-alive mechanism #65812

panjf2000 opened this issue Feb 20, 2024 · 2 comments
Assignees
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. OS-illumos OS-Solaris
Milestone

Comments

@panjf2000
Copy link
Member

panjf2000 commented Feb 20, 2024

Oracle Solaris claimed it supported the TCP-Alives mechanism, but TCP_KEEPIDLE, TCP_KEEPINTVL, and TCP_KEEPCNT were not available on Solaris until the latest version 11.4. If we want to achieve the full TCP-Alives mechanism on solaris (<11.4) that already exists on other platforms, we can only do it by simulating it via TCP_KEEPALIVE_THRESHOLD + TCP_KEEPALIVE_ABORT_THRESHOLD.

Meanwhile, illumos has supported TCP_KEEPIDLE, TCP_KEEPINTVL, and TCP_KEEPCNT a year after it was forked from OpenSolaris (2011). And since GOOS=illumos implies the solaris build tag in Go, illumos and solaris share the same TCP keep-alive implementation, Go programs running on illumos won't be able to benefit from the full TCP keep-alive feature implemented by CL 542275. Besides, issues like #9614 and #64251 are even stirring things up. Therefore, we should split illumos out of solaris on TCP keep-alive.

Follows up #65809

References:

@panjf2000 panjf2000 added OS-Solaris NeedsFix The path to resolution is known, but the work has not been done. OS-illumos labels Feb 20, 2024
@panjf2000 panjf2000 added this to the Go1.23 milestone Feb 20, 2024
@gopherbot
Copy link

Change https://go.dev/cl/565335 mentions this issue: net: split the illumos out of solaris on TCP keep-alive mechanism

@panjf2000 panjf2000 changed the title net: split the illumos out of solaris on TCP keep-alive mechanism net: split illumos out of solaris on TCP keep-alive mechanism Feb 20, 2024
@panjf2000 panjf2000 self-assigned this Feb 20, 2024
@panjf2000 panjf2000 modified the milestones: Go1.23, Backlog Feb 21, 2024
@gopherbot
Copy link

Change https://go.dev/cl/575015 mentions this issue: net: split illumos out of solaris on TCP keep-alive mechanism

@panjf2000 panjf2000 modified the milestones: Backlog, Go1.23 Apr 5, 2024
@panjf2000 panjf2000 added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. OS-illumos OS-Solaris
Projects
None yet
Development

No branches or pull requests

2 participants