Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestDNSThreadLimit makes tests fail when CGO_ENABLED=0 or with -tags netgo #6580

Closed
mikioh opened this issue Oct 13, 2013 · 6 comments
Closed

net: TestDNSThreadLimit makes tests fail when CGO_ENABLED=0 or with -tags netgo #6580

mikioh opened this issue Oct 13, 2013 · 6 comments
Labels
FrozenDueToAge

Comments

@mikioh
Copy link
Contributor

mikioh commented Oct 13, 2013 

For example, 

go env | grep CGO
CGO_ENABLED="0"
go test 
--- FAIL: TestDialGoogleIPv4 (0.00 seconds)
    dialgoogle_test.go:143: lookup www.google.com: dial udp 8.8.8.8:53: too many open files
--- FAIL: TestTCPLookup (0.00 seconds)
    dnsclient_unix_test.go:19: Dial failed: dial tcp 8.8.8.8:53: too many open files
FAIL
exit status 1
FAIL    net 18.816s

or

% go env | grep CGO
CGO_ENABLED="1"
% go build -tags netgo  .
% go test -tags netgo
--- FAIL: TestDialGoogleIPv4 (0.00 seconds)
    dialgoogle_test.go:143: lookup www.google.com: dial udp 8.8.8.8:53: too many open files
--- FAIL: TestTCPLookup (0.00 seconds)
    dnsclient_unix_test.go:19: Dial failed: dial tcp 8.8.8.8:53: too many open files
FAIL
exit status 1
FAIL    net 18.695s
@ianlancetaylor
Copy link
Contributor

Comment 1:

Since this test is not run by default, and you are talking about a non-default
configuration, I don't think it is important to fix for Go 1.2.

Labels changed: added go1.2maybe, removed go1.2.

@mikioh
Copy link
Contributor Author

mikioh commented Oct 13, 2013

Comment 2:

Labels changed: added go1.3maybe, removed go1.2maybe.

@mikioh
Copy link
Contributor Author

mikioh commented Oct 17, 2013

Comment 3:

https://golang.org/cl/14639044/

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 4:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

rsc commented Dec 4, 2013

Comment 5:

Labels changed: added repo-main.

@mikioh
Copy link
Contributor Author

mikioh commented Dec 18, 2013

Comment 6:

This issue was closed by revision f439e07.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mikioh @rsc @ianlancetaylor @gopherbot