Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: builtins with lowercase names not searchable #65781

Open
seebs opened this issue Feb 18, 2024 · 0 comments
Open

x/pkgsite: builtins with lowercase names not searchable #65781

seebs opened this issue Feb 18, 2024 · 0 comments
Labels
pkgsite/search Issues related to pkg.go.dev search functionality pkgsite

Comments

@seebs
Copy link
Contributor

seebs commented Feb 18, 2024

What is the URL of the page with the issue?

https://pkg.go.dev/search?q=builtin.make&m=symbol

What is your user agent?

firefox

Screenshot

sorry, don't have one handy

What did you do?

search for make on pkg.go.dev

What did you see happen?

results for Make

What did you expect to see?

builtin.make, aka the make function that's part of the base language.

it looks to me like pkg.go.dev is (correctly for EVERY OTHER case) only searching for exported symbols, but for the handful of language builtins (make, min, max, nil, etc) with lowercase names that are predeclared identifiers, this isn't working.

@seebs seebs added the pkgsite label Feb 18, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 18, 2024
@seankhliao seankhliao added the pkgsite/search Issues related to pkg.go.dev search functionality label Feb 19, 2024
@hyangah hyangah modified the milestones: Unreleased, pkgsite/search Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkgsite/search Issues related to pkg.go.dev search functionality pkgsite
Projects
None yet
Development

No branches or pull requests

4 participants