You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Due (I think) to precise pruning in the go command, the fix for #64888 doesn't really work: locally replaced modules may have spurious import errors in packages that are pruned, due to missing go.sum entries. I think I was overfitting to the Kubernetes use-case.
Therefore, we should at least temporarily revert this behavior until we figure out something better. In general, even a locally replaced module must be loaded as a separate build, as only the local go.sum will be complete.
Fortunately, we can just revert the default value of "includeReplaceInWorkspace".
gopherbot
added
Tools
This label describes issues relating to any tools in the x/tools repository.
gopls
Issues related to the Go language server, gopls.
labels
Feb 16, 2024
…ReplaceInWorkspace" to false
As described in golang/go#65762, treating locally replaced modules the
same as workspace modules doesn't really work, since there will be
missing go.sum entries. Fortunately, this functionality was guarded by
the "includeReplaceInWorkspace" setting. Revert the default value for
this setting.
Fixesgolang/go#65762
Change-Id: I521acb2863404cba7612887aa7730075dcfebd96
Reviewed-on: https://go-review.googlesource.com/c/tools/+/564558
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
(cherry picked from commit 3ac77cb)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/564559
Auto-Submit: Robert Findley <rfindley@google.com>
Due (I think) to precise pruning in the go command, the fix for #64888 doesn't really work: locally replaced modules may have spurious import errors in packages that are pruned, due to missing go.sum entries. I think I was overfitting to the Kubernetes use-case.
Therefore, we should at least temporarily revert this behavior until we figure out something better. In general, even a locally replaced module must be loaded as a separate build, as only the local go.sum will be complete.
Fortunately, we can just revert the default value of "includeReplaceInWorkspace".
CC @adonovan
The text was updated successfully, but these errors were encountered: