Skip to content

x/build/cmd/relui: add a workflow for publishing private patches to golang.org/x repos #65756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rolandshoemaker opened this issue Feb 16, 2024 · 6 comments
Closed

x/build/cmd/relui: add a workflow for publishing private patches to golang.org/x repos #65756

rolandshoemaker opened this issue Feb 16, 2024 · 6 comments
Assignees
@rolandshoemaker
Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@rolandshoemaker
Copy link
Member

Patches for golang.org/x/ repos are developed on a private, internal Gerrit instance. Once a patch is approved and ready for release, a number of manual steps have to be taken to publish said patch to the public instance, merge it, tag a module release, and announce the fix. All of these steps can be automated using a relui workflow.

cc @golang/release @dmitshur
@rolandshoemaker rolandshoemaker added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 16, 2024
@rolandshoemaker rolandshoemaker self-assigned this Feb 16, 2024
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 16, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 16, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/559295 mentions this issue: internal/task: add a workflow for publishing private x/ patches

@dmitshur dmitshur moved this to In Progress in Go Release Feb 17, 2024
@dmitshur dmitshur mentioned this issue Feb 22, 2024
Open
gopherbot pushed a commit to golang/build that referenced this issue Feb 26, 2024
@rolandshoemaker @gopherbot
internal/task: add a workflow for publishing private x/ patches
9005598 
This adds a workflow to relui which takes a patch from the private
internal gerrit instance for one of the golang.org/x/ repos and sends it
to the public gerrit, waits for it to be submitted, tags the repo, and
emails an announcement message to the various lists.

Requires a minor change to the HTML workflow template to allow for
non-slice textareas.

Updates golang/go#65756

Change-Id: Ica1ec5982545ddd7fff1e71bd33eb3281572017d
Reviewed-on: https://go-review.googlesource.com/c/build/+/559295
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/566995 mentions this issue: internal/task: use authenticated git client in priv patch workflow

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/567035 mentions this issue: internal/task: return useful errors in priv patch workflow

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/567055 mentions this issue: internal/task: convert reviewer names to emails for priv patch workflow

gopherbot pushed a commit to golang/build that referenced this issue Mar 4, 2024
@rolandshoemaker
internal/task: use authenticated git client in priv patch workflow
0b09433 
For golang/go#65756.

Change-Id: Iec9bfcd1ed02913323dc8e20a6b6eeb0eddf7f51
Reviewed-on: https://go-review.googlesource.com/c/build/+/566995
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
gopherbot pushed a commit to golang/build that referenced this issue Mar 4, 2024
@rolandshoemaker @gopherbot
internal/task: return useful errors in priv patch workflow
54dce9a 
For golang/go#65756.

Change-Id: Iefa4395f381e1306837cac048ea5e9b1c68d7610
Reviewed-on: https://go-review.googlesource.com/c/build/+/567035
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Auto-Submit: Roland Shoemaker <roland@golang.org>
gopherbot pushed a commit to golang/build that referenced this issue Mar 4, 2024
@rolandshoemaker @gopherbot
internal/task: convert reviewer names to emails for priv patch workflow
e2a6122 
For golang/go#65756.

Change-Id: I4dac7da7e68bf545103b99bf7a2f09374397f986
Reviewed-on: https://go-review.googlesource.com/c/build/+/567055
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
Auto-Submit: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@rolandshoemaker
Copy link
Member Author

Closing, this is basically done now.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Release Apr 23, 2024
@gabyhelp gabyhelp mentioned this issue Aug 14, 2024
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/647375 mentions this issue: internal/task: update private x patch workflow

gopherbot pushed a commit to golang/build that referenced this issue Feb 18, 2025
@rolandshoemaker @gopherbot
internal/task: update private x patch workflow
Loading
Loading status checks…
7689d41 
To match our new checkpoint branch based workflow, this now matches the
same workflow we use when constructing the internal release branches
for minor releases.

Updates golang/go#65756

Change-Id: I4a58e1f66b909a51e498e924023d3a776a920ed7
Reviewed-on: https://go-review.googlesource.com/c/build/+/647375
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Auto-Submit: Roland Shoemaker <roland@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolandshoemaker rolandshoemaker

Labels
Builders x/build issues (builders, bots, dashboards) NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@rolandshoemaker @gopherbot