You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The testenv package defines a number of helpers for skipping tests. One of them checks that go env GOROOT and runtime.GOROOT agree; if not, it skips the test. (Perhaps it should fatal? But I digress.)
When running with GODEBUG=countertrace, the go env command prints a bunch of stuff to stderr, as it should. However, testenv runs the command and then gathers its CombinedOutput (2>&1), which means it is no longer a well-formed go env result. Mayhem ensues.
No Go program should attempt to parse CombinedOutput. It is for human eyes only (or tests that look for fragments of error messages among the wreckage).
The text was updated successfully, but these errors were encountered:
gopherbot
added
the
Tools
This label describes issues relating to any tools in the x/tools repository.
label
Feb 15, 2024
I fumbled with git and forked the CL, stranding some review
comments from bcmills on the ill-fated fork.
Updates golang/go#65729
Change-Id: I6d0bf431f841dacb94e9e13a90bf39f8e2ed2fbf
Reviewed-on: https://go-review.googlesource.com/c/tools/+/564339
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Alan Donovan <adonovan@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The testenv package defines a number of helpers for skipping tests. One of them checks that
go env GOROOT
andruntime.GOROOT
agree; if not, it skips the test. (Perhaps it should fatal? But I digress.)When running with GODEBUG=countertrace, the go env command prints a bunch of stuff to stderr, as it should. However, testenv runs the command and then gathers its CombinedOutput (
2>&1
), which means it is no longer a well-formed go env result. Mayhem ensues.No Go program should attempt to parse CombinedOutput. It is for human eyes only (or tests that look for fragments of error messages among the wreckage).
The text was updated successfully, but these errors were encountered: