Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/dist: add a test checking that only approved modules are vendored #65678

Open
jba opened this issue Feb 12, 2024 · 1 comment
Open

cmd/dist: add a test checking that only approved modules are vendored #65678

jba opened this issue Feb 12, 2024 · 1 comment
Assignees
@jba
Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.23

Comments

@jba
Copy link
Contributor

jba commented Feb 12, 2024

Add a test to the cmd/dist package that compares the modules in src/vendor and src/cmd/vendor against a list of allowed module globs.
@jba jba self-assigned this Feb 12, 2024
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 12, 2024
@dmitshur dmitshur added this to the Go1.23 milestone Feb 12, 2024
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Feb 12, 2024
@gopherbot
Copy link

Change https://go.dev/cl/564355 mentions this issue: src/cmd/dist: add check for allowed vendor modules

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. FixPending Issues that have a fix which has not yet been reviewed or submitted. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 15, 2024
gopherbot pushed a commit that referenced this issue Feb 28, 2024
@jba
go/build: add check for allowed vendor packages
f865440 
Add a test that checks that all vendored packages in both src/ and
src/cmd are on an allowlist.

For #65678.

Change-Id: Ie9982f8b69c9c0fc6fef41c9dadeb464ecd7781a
Reviewed-on: https://go-review.googlesource.com/c/go/+/564355
Reviewed-by: Bryan Mills <bcmills@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jba jba

Labels
FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.23
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @jba