Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

encoding/csv: reader wrongly parses quoted trailing quotes and merges neighboring items #65661

Closed
teghnet opened this issue Feb 11, 2024 · 2 comments
Closed

encoding/csv: reader wrongly parses quoted trailing quotes and merges neighboring items #65661

teghnet opened this issue Feb 11, 2024 · 2 comments

Comments

@teghnet
Copy link

teghnet commented Feb 11, 2024

Go version

go version go1.22.0 linux/amd64

Output of go env in your module/workspace:

GO111MODULE='on'
GOARCH='amd64'
GOBIN=''
GOCACHE='/.cache/go-build'
GOENV='/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/go/go1.22.0'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/go/go1.22.0/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.22.0'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/projects/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build3421635005=/tmp/go-build -gno-record-gcc-switches'

What did you do?

I was parsing a simple CSV file.

see: https://go.dev/play/p/0oemKdT4_dg

The easiest way to show the problem is in a test.
This test in src/encoding/csv/reader_test.go should pass

{
	Name:       "QuotedLazyQuotes",
	Input:      `§"a "word"",§"1"2",§a",§"b`,
	Output:     [][]string{{`a "word"`, `1"2`, `a"`, `b`}},
	LazyQuotes: true,
}

What did you see happen?

The result was wrong. I got a single cell with the comma inside.

What did you expect to see?

We should be seeing 2 separate cells.
@teghnet teghnet mentioned this issue Feb 11, 2024
Closed
@seankhliao
Copy link
Member

Duplicate of #56329

@seankhliao seankhliao marked this as a duplicate of #56329 Feb 11, 2024
@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Feb 11, 2024
@teghnet
Copy link
Author

teghnet commented Feb 13, 2024 •
edited

Thanks @. Didn't find that other reported issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teghnet @seankhliao