cmd/go: go 1.22.0: go test throws errors when processing folders not listed in coverpkg argument #65653

sonic-martin · 2024-02-10T22:21:49Z

Go version

go version go1.22.0 linux/amd64, go version go1.22.0 darwin/amd64, go version go1.22.0 windows/amd64

Output of `go env` in your module/workspace:

GO111MODULE=''
GOARCH='amd64'
GOBIN='/home/martin/bin'
GOCACHE='/home/martin/.cache/go-build'
GOENV='/home/martin/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/mnt/c/dev/git/pkg/mod'
GONOPROXY='*.mycompany.com'
GONOSUMDB='*.mycompany.com'
GOOS='linux'
GOPATH='/mnt/c/dev/git'
GOPRIVATE='*.mycompany.com'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/mnt/c/dev/git/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.0.linux-amd64'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/mnt/c/dev/git/pkg/mod/golang.org/toolchain@v0.0.1-go1.22.0.linux-amd64/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.22.0'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/mnt/c/dev/git/golang-test-cover/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build2876750124=/tmp/go-build -gno-record-gcc-switches'

What did you do?

Have a main.go and a package internal with some functions.

See reproducer: https://github.com/sonic-martin/golang-test-cover

Run go test:

go test -v ./... -coverprofile=coverage.out -coverpkg=./internal/... -covermode count
go tool cover -html=coverage.out -o coverage.html
go tool cover -func=coverage.out

What did you see happen?

$ go test -v ./... -coverprofile=coverage.out -coverpkg=./internal/... -covermode count
example.com/m: open /tmp/go-build1123786392/b002/covmeta.f6e4431d5ec1fd71f02b3ce4e56eb691a86525173d917007425576a7d9db7c72: no such file or directory
=== RUN   TestHelloer
--- PASS: TestHelloer (0.00s)
PASS
coverage: 100.0% of statements in ./internal/...
ok      example.com/m/internal  0.003s  coverage: 100.0% of statements in ./internal/...
$ echo $?
1
$ go tool cover -html=coverage.out -o coverage.html
$ go tool cover -func=coverage.out
example.com/m/internal/helloer.go:3:    Helloer         100.0%
total:                                  (statements)    100.0%

coverage.out:

mode: count
example.com/m/internal/helloer.go:3.23,5.2 1 1

The both outputs of go tool cover are fine.

What did you expect to see?

Before go 1.22.0 it worked fine and no no such file or directory errors happend.

There are two workarounds:

(1) go test with -coverpkg equal to the folder/packages processed

go test -v ./... -coverprofile=coverage.out -coverpkg=./... -covermode count
        example.com/m           coverage: 0.0% of statements
=== RUN   TestHelloer
--- PASS: TestHelloer (0.00s)
PASS
coverage: 50.0% of statements in ./...
ok      example.com/m/internal  0.003s  coverage: 50.0% of statements in ./...

But changes semantic of the coverage result.

(2) go test with GOEXPERIMENT=nocoverageredesign

$ GOEXPERIMENT=nocoverageredesign go test -v ./... -coverprofile=coverage.out -coverpkg=./internal/... -covermode count
?       example.com/m   [no test files]
=== RUN   TestHelloer
--- PASS: TestHelloer (0.00s)
PASS
coverage: 100.0% of statements in ./internal/...
ok      example.com/m/internal  0.002s  coverage: 100.0% of statements in ./internal/...

See the discussion from Brian Candler, Aldemar F, Thomas McNulty and me in the mailing list:
https://groups.google.com/g/golang-nuts/c/PjAWIdSdQHc

The text was updated successfully, but these errors were encountered:

aldemarf · 2024-02-12T11:47:48Z

Thanks for opening this issue, Martin.

thanm · 2024-02-12T15:01:55Z

Thanks for the report. I will take a look.

shaxbee · 2024-02-21T04:31:35Z

Got bunch of CI pipelines broken after 1.22 upgrade with same covmeta.[hash]: no such file or directory error for packages with no tests.
Only setting GOEXPERIMENT=nocoverageredesign or reverting back to 1.21 is fixing it ATM.

Edit:
Setting GOEXPERIMENT=nocoverageredesign is disabling go build -covermode -coverpkg flags, effectively breaking build.

zegerius · 2024-02-22T07:57:57Z

Looks like this was introduced in 36e75f6

fredbi · 2024-03-04T09:10:24Z

I am also facing this problem, but the go test program returns an exit status specifically on windows only

Adding smoke tests in all packages to circumvent go1.22 issue: golang/go#65653 Signed-off-by: Frederic BIDON <fredbi@yahoo.com>

gopherbot · 2024-03-04T16:38:06Z

Change https://go.dev/cl/568835 mentions this issue: cmd/go: respect -coverpkg for unselected no-test packages

thanm · 2024-03-04T16:44:00Z

Thanks for the reports. I have sent a patch https://go.dev/cl/568835 that should fix this issue, if anyone wants to try it out.

zegerius · 2024-03-05T08:20:35Z

@thanm I tested in two projects and experience no more issues after applying your patch. Thanks, looking forward to the release.

kavu · 2024-03-05T18:31:16Z

@thanm Hi! As this fix already flew over the 1.22.1, may we hope that it will be cherry-picked to 1.22.2? I have high hopes for it, we have several dozens of broken pipelines here. Thank you in advance!

thanm · 2024-03-05T18:40:57Z

cherry-picked to 1.22.2?

I will bring up this possibility with the release team, but given that there is a workaround it seems unlikely that this sort of backport would be approved. Backports are generally reserved for serious problems (compiler or runtime crash, incorrect results, etc) with no workaround. We'll see.

kavu · 2024-03-06T01:03:02Z

Thank you!

Yeah, we already keep in mind workaround with GOEXPERIMENT=nocoverageredesign, but just trying to keep faith that we won't have to wait till 1.23. Thank you again for your work!

See golang/go#65653, the fix can be postponed up to Go 1.23 and we need green. Signed-off-by: Roman Khimov <roman@nspcc.ru>

muhlemmer · 2024-03-06T11:24:45Z

For what it's worth, applying the patch on the 1.22 release branch for my local builds works fine.

thanm · 2024-03-06T17:22:16Z

@gopherbot please consider this for backport to 1.22

gopherbot · 2024-03-06T17:22:48Z

Backport issue(s) opened: #66137 (for 1.22).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

gopherbot · 2024-03-06T17:27:43Z

Change https://go.dev/cl/569575 mentions this issue: cmd/go: respect -coverpkg for unselected no-test packages

This fixes a bug with the CI tests that was introduced with the upgrade to Go version 1.22.1 due to changes in how the "coverpkg" argument works, see: golang/go#65653. - Modify Makefile test and test-race targets based on artefactual-sdps/enduro targets - Add Makefile test-ci target from artefactual-sdps/enduro - Update .github/workflows/test.yml to use `make test-ci` to run tests - Delete hack/coverpkgs.sh

thediveo · 2024-03-14T13:36:33Z

Has this landed on gotip yet? I run into this issue using gotip just pulled a few moments ago.

thanm · 2024-03-14T13:53:54Z

Yes, this is landed on tip. If you are still seeing it (or something like it) I would be interested in a reproducer.

thediveo · 2024-03-14T14:01:34Z

Thanks! It seems it was a problem of the shell alias not carrying into a shell script.

…est packages This patch fixes a bug in the code that reports coverage percentages and/or profiles for packages without tests. Specifically, the code added as part of the fix for issue 24570 (in CL 495447) didn't properly consider the -coverpkg selection and would look for the build action meta-data file for a package that wasn't actually selected for coverage. Updates #65653. Fixes #66137. Change-Id: I66ffac11783c00a8cbd855fd05b9a90e4e0ed402 Reviewed-on: https://go-review.googlesource.com/c/go/+/568835 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Bryan Mills <bcmills@google.com> (cherry picked from commit 2b22fc1) Reviewed-on: https://go-review.googlesource.com/c/go/+/569575

thanm self-assigned this Feb 12, 2024

thanm added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 12, 2024

bcmills added the GoCommand cmd/go label Feb 14, 2024

bcmills added this to the Backlog milestone Feb 15, 2024

fredbi added a commit to fredbi/runtime that referenced this issue Mar 4, 2024

test: added tests in all packages

f04577f

Adding smoke tests in all packages to circumvent go1.22 issue: golang/go#65653 Signed-off-by: Frederic BIDON <fredbi@yahoo.com>

fredbi added a commit to go-openapi/runtime that referenced this issue Mar 4, 2024

test: added tests in all packages

8560f81

Adding smoke tests in all packages to circumvent go1.22 issue: golang/go#65653 Signed-off-by: Frederic BIDON <fredbi@yahoo.com>

thanm mentioned this issue Mar 4, 2024

internal/goexperiment: remove CoverageRedesign some time in 1.23 #55953

Open

gopherbot closed this as completed in 2b22fc1 Mar 4, 2024

roman-khimov added a commit to nspcc-dev/neo-go that referenced this issue Mar 6, 2024

workflows: workaround Go 1.22 coverage problem

d31b01d

See golang/go#65653, the fix can be postponed up to Go 1.23 and we need green. Signed-off-by: Roman Khimov <roman@nspcc.ru>

roman-khimov mentioned this issue Mar 6, 2024

workflows: workaround Go 1.22 coverage problem nspcc-dev/neo-go#3339

Merged

gopherbot mentioned this issue Mar 6, 2024

cmd/go: go 1.22.0: go test throws errors when processing folders not listed in coverpkg argument [1.22 backport] #66137

Closed

dmathieu mentioned this issue Mar 11, 2024

Temporarily ignore folders that are not actual modules in coverage check elastic/apm-agent-go#1579

Merged

thanm mentioned this issue Mar 11, 2024

cmd/go: test coverage command fails after update to v1.22 #66211

Closed

muhlemmer mentioned this issue Mar 20, 2024

cmd/go: go test with nocoverageredesign uses huge amount temp files #66428

Closed

newtondev mentioned this issue Mar 26, 2024

fix(deps): updated dependencies and interface changes metacontroller/metacontroller#968

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/go: go 1.22.0: go test throws errors when processing folders not listed in coverpkg argument #65653

cmd/go: go 1.22.0: go test throws errors when processing folders not listed in coverpkg argument #65653

sonic-martin commented Feb 10, 2024 •

edited

aldemarf commented Feb 12, 2024

thanm commented Feb 12, 2024

shaxbee commented Feb 21, 2024 •

edited

zegerius commented Feb 22, 2024

fredbi commented Mar 4, 2024

gopherbot commented Mar 4, 2024

thanm commented Mar 4, 2024

zegerius commented Mar 5, 2024

kavu commented Mar 5, 2024

thanm commented Mar 5, 2024

kavu commented Mar 6, 2024 •

edited

muhlemmer commented Mar 6, 2024

thanm commented Mar 6, 2024

gopherbot commented Mar 6, 2024

gopherbot commented Mar 6, 2024

thediveo commented Mar 14, 2024

thanm commented Mar 14, 2024

thediveo commented Mar 14, 2024

cmd/go: go 1.22.0: go test throws errors when processing folders not listed in coverpkg argument #65653

cmd/go: go 1.22.0: go test throws errors when processing folders not listed in coverpkg argument #65653

Comments

sonic-martin commented Feb 10, 2024 • edited

Go version

Output of go env in your module/workspace:

What did you do?

What did you see happen?

What did you expect to see?

aldemarf commented Feb 12, 2024

thanm commented Feb 12, 2024

shaxbee commented Feb 21, 2024 • edited

zegerius commented Feb 22, 2024

fredbi commented Mar 4, 2024

gopherbot commented Mar 4, 2024

thanm commented Mar 4, 2024

zegerius commented Mar 5, 2024

kavu commented Mar 5, 2024

thanm commented Mar 5, 2024

kavu commented Mar 6, 2024 • edited

muhlemmer commented Mar 6, 2024

thanm commented Mar 6, 2024

gopherbot commented Mar 6, 2024

gopherbot commented Mar 6, 2024

thediveo commented Mar 14, 2024

thanm commented Mar 14, 2024

thediveo commented Mar 14, 2024

sonic-martin commented Feb 10, 2024 •

edited

Output of `go env` in your module/workspace:

shaxbee commented Feb 21, 2024 •

edited

kavu commented Mar 6, 2024 •

edited