Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/cgo/internal/testsanitizers,x/build: LUCI clang15 builders failing [1.22 backport] #65641

Closed
gopherbot opened this issue Feb 9, 2024 · 2 comments
Closed

cmd/cgo/internal/testsanitizers,x/build: LUCI clang15 builders failing [1.22 backport] #65641

gopherbot opened this issue Feb 9, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.22.1

Comments

@gopherbot
Copy link

@mknyszek requested issue #65469 to be considered for backport to the next 1.22 minor release.

@gopherbot Please open backport issues for Go 1.21 and Go 1.22. The LUCI clang builder on those branches is currently broken, and we should cherry-pick the fix applied here.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 9, 2024
@gopherbot gopherbot mentioned this issue Feb 9, 2024
Closed
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 9, 2024
@mknyszek mknyszek added Testing An issue that has been verified to require only test changes, not just a test failure. and removed Builders x/build issues (builders, bots, dashboards) labels Feb 9, 2024
@gopherbot gopherbot modified the milestones: Unreleased, Go1.22.1 Feb 9, 2024
@mknyszek mknyszek changed the title x/build: LUCI clang15 builders failing [1.22 backport] cmd/cgo/internal/testsanitizers,x/build: LUCI clang15 builders failing [1.22 backport] Feb 9, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/563015 mentions this issue: [release-branch.go1.22] cmd/cgo/internal/testsanitizers: disable location checking for clang

@thanm thanm added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Feb 14, 2024
gopherbot pushed a commit that referenced this issue Feb 16, 2024
@mknyszek @thanm
[release-branch.go1.22] cmd/cgo/internal/testsanitizers: disable loca…
d6a2719 
…tion checking for clang

Pending a resolution to #65606, this CL marks clang's ASAN runtime as
unable to symbolize stack traces to unblock the LUCI clang builder.

For #65606.
For #65469.
Fixes #65641.

Change-Id: I649773085aff30e5703e7f7ac2c72a0430a015c2
Cq-Include-Trybots: luci.golang.try:go1.22-linux-amd64-clang15
Reviewed-on: https://go-review.googlesource.com/c/go/+/562675
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit d94ab59)
Reviewed-on: https://go-review.googlesource.com/c/go/+/563015
@gopherbot
Copy link
Author

Closed by merging d6a2719 to release-branch.go1.22.

bradfitz pushed a commit to tailscale/go that referenced this issue Mar 5, 2024
@mknyszek @bradfitz
[release-branch.go1.22] cmd/cgo/internal/testsanitizers: disable loca…
20e5874 
…tion checking for clang

Pending a resolution to golang#65606, this CL marks clang's ASAN runtime as
unable to symbolize stack traces to unblock the LUCI clang builder.

For golang#65606.
For golang#65469.
Fixes golang#65641.

Change-Id: I649773085aff30e5703e7f7ac2c72a0430a015c2
Cq-Include-Trybots: luci.golang.try:go1.22-linux-amd64-clang15
Reviewed-on: https://go-review.googlesource.com/c/go/+/562675
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit d94ab59)
Reviewed-on: https://go-review.googlesource.com/c/go/+/563015
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 6, 2024
@mknyszek @romaindoumenc
[release-branch.go1.22] cmd/cgo/internal/testsanitizers: disable loca…
e081268 
…tion checking for clang

Pending a resolution to golang#65606, this CL marks clang's ASAN runtime as
unable to symbolize stack traces to unblock the LUCI clang builder.

For golang#65606.
For golang#65469.
Fixes golang#65641.

Change-Id: I649773085aff30e5703e7f7ac2c72a0430a015c2
Cq-Include-Trybots: luci.golang.try:go1.22-linux-amd64-clang15
Reviewed-on: https://go-review.googlesource.com/c/go/+/562675
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit d94ab59)
Reviewed-on: https://go-review.googlesource.com/c/go/+/563015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.22.1
Development

No branches or pull requests
3 participants
@mknyszek @gopherbot @thanm