Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: Go 1.22 changes support for modules that declare go 1.0 [1.22 backport] #65619

Closed
gopherbot opened this issue Feb 8, 2024 · 2 comments
Closed

cmd/compile: Go 1.22 changes support for modules that declare go 1.0 [1.22 backport] #65619

gopherbot opened this issue Feb 8, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.22.1

Comments

@gopherbot
Copy link

@bcmills requested issue #65528 to be considered for backport to the next 1.22 minor release.

@gopherbot, please backport to Go 1.22. This was a regression in 1.22.0 and the fix is trivial.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 8, 2024
@gopherbot gopherbot mentioned this issue Feb 8, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 8, 2024
@gopherbot gopherbot added this to the Go1.22.1 milestone Feb 8, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/562815 mentions this issue: cmd/compile: accept -lang=go1 as -lang=go1.0

@anitgandhi anitgandhi mentioned this issue Feb 9, 2024
Open
@thanm thanm added CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Feb 14, 2024
gopherbot pushed a commit that referenced this issue Feb 16, 2024
@mdempsky @thanm
[release-branch.go1.22] cmd/compile: accept -lang=go1 as -lang=go1.0
fb86598 
Fixes #65619.

Change-Id: I55fef8cf7be4654c7242462d45f12999e0c91c02
Reviewed-on: https://go-review.googlesource.com/c/go/+/562322
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 08370dc)
Reviewed-on: https://go-review.googlesource.com/c/go/+/562815
@gopherbot
Copy link
Author

Closed by merging fb86598 to release-branch.go1.22.

bradfitz pushed a commit to tailscale/go that referenced this issue Mar 5, 2024
@mdempsky @bradfitz
[release-branch.go1.22] cmd/compile: accept -lang=go1 as -lang=go1.0
a943b11 
Fixes golang#65619.

Change-Id: I55fef8cf7be4654c7242462d45f12999e0c91c02
Reviewed-on: https://go-review.googlesource.com/c/go/+/562322
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 08370dc)
Reviewed-on: https://go-review.googlesource.com/c/go/+/562815
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 6, 2024
@mdempsky @romaindoumenc
[release-branch.go1.22] cmd/compile: accept -lang=go1 as -lang=go1.0
1ccda09 
Fixes golang#65619.

Change-Id: I55fef8cf7be4654c7242462d45f12999e0c91c02
Reviewed-on: https://go-review.googlesource.com/c/go/+/562322
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 08370dc)
Reviewed-on: https://go-review.googlesource.com/c/go/+/562815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.22.1
Development

No branches or pull requests
2 participants
@gopherbot @thanm