Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: Go 1.22 build fails with 1.21 PGO profile on internal/saferio change [1.21 backport] #65617

Closed
gopherbot opened this issue Feb 8, 2024 · 1 comment
Closed

cmd/compile: Go 1.22 build fails with 1.21 PGO profile on internal/saferio change [1.21 backport] #65617

gopherbot opened this issue Feb 8, 2024 · 1 comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime.
Milestone
Go1.21.8

Comments

@gopherbot
Copy link

@prattmic requested issue #65615 to be considered for backport to the next 1.21 minor release.

@gopherbot Please backport to 1.21 and 1.22. This is a build failure with PGO if a hot function is changed from non-generic to generic. Only workarounds are to rename the symbol or disable PGO.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 8, 2024
@gopherbot gopherbot mentioned this issue Feb 8, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 8, 2024
@gopherbot gopherbot added this to the Go1.21.8 milestone Feb 8, 2024
@prattmic
Copy link
Member

prattmic commented Feb 9, 2024

I misremembered; export data lookup was only added in 1.22 (https://go.dev/cl/497175), so this bug doesn't apply to 1.21.

@prattmic prattmic closed this as completed Feb 9, 2024
@prattmic prattmic closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2024
@dmitshur dmitshur removed the CherryPickCandidate Used during the release process for point releases label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime.
Projects
None yet
Milestone
Go1.21.8
Development

No branches or pull requests
3 participants
@prattmic @dmitshur @gopherbot