Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/telemetry: go version should match that of gopls #65598

Open
pjweinb opened this issue Feb 8, 2024 · 1 comment
Open

x/telemetry: go version should match that of gopls #65598

pjweinb opened this issue Feb 8, 2024 · 1 comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Milestone

Comments

@pjweinb
Copy link

pjweinb commented Feb 8, 2024

Go version

go version go1l21l4 darwin/amd

Output of go env in your module/workspace:

irrelevant

What did you do?

opened the telemetry repository

What did you see happen?

the go version in go.mod is 1.20, while that in the gopls go.mod is g1.18

What did you expect to see?

Telemetry has to work with gopls, and gopls by policy works for older versions of Go. Shouldn't the version of go in the telemetry go.mod file match the one in the gopls gol.mod file?

@gopherbot gopherbot added the telemetry x/telemetry issues label Feb 8, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 8, 2024
@thanm thanm added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 12, 2024
@hyangah
Copy link
Contributor

hyangah commented Feb 12, 2024

x/telemetry works with go1.18 and go1.19 (just everything is noop and is supposed to be buildtag protected).
go1.20 is the last version where the go version in go.mod does not enforce the importing module to upgrade the go version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues
Projects
None yet
Development

No branches or pull requests

4 participants