Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/relui: skip perf and known-issue builders in builder selection #65589

Closed
dmitshur opened this issue Feb 7, 2024 · 4 comments
Closed

x/build/cmd/relui: skip perf and known-issue builders in builder selection #65589

dmitshur opened this issue Feb 7, 2024 · 4 comments
Assignees
@dmitshur
Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Feb 7, 2024

There are new builders in LUCI meant for performance evaluation, not testing. They're currently being picked up by relui's advisory builder selection and get run, which isn't quite working as intended (but it is working). This is a tracking bug to filter them out.

CC @dmitshur, @mknyszek.
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 7, 2024
@dmitshur dmitshur added this to the Unreleased milestone Feb 7, 2024
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 7, 2024
@dmitshur dmitshur self-assigned this Feb 12, 2024
@dmitshur
Copy link
Contributor Author

The tagging workflow is also running into this, and it doesn't have the option letting the human operator skip the non-applicable perf builders like the advisory builders.

While here, I'll also take care of skipping builders that are marked with a non-zero known issue (such as when a new builder is still in the process of being added).

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 12, 2024
@dmitshur dmitshur changed the title x/build/cmd/relui: skip perf builders in advisory builder selection x/build/cmd/relui: skip perf and known-issue builders in builder selection Feb 12, 2024
@gopherbot
Copy link

Change https://go.dev/cl/563375 mentions this issue: main.star: add known_issue property to builders (when it's non-zero)

@gopherbot
Copy link

Change https://go.dev/cl/563395 mentions this issue: internal/relui, internal/task: skip perf and known issue builders

@dmitshur dmitshur added the FixPending Issues that have a fix which has not yet been reviewed or submitted. label Feb 12, 2024
gopherbot pushed a commit to golang/build that referenced this issue Feb 12, 2024
@dmitshur @gopherbot
main.star: add known_issue property to builders (when it's non-zero)
c9e02ca 
This makes it possible to determine whether a given builder has a known
issue or not. Needed for some tooling in x/build (e.g., relui) which is
reading a list of builders relevant to a given task. The is_google prop
exists for similar reasons.

For golang/go#65589.

Change-Id: Ie3d74c3d6ddfb4dbff940f007da6aa6f3caf7676
Reviewed-on: https://go-review.googlesource.com/c/build/+/563375
Reviewed-by: Michael Knyszek <mknyszek@google.com>
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmitshur@golang.org>
@dmitshur
Copy link
Contributor Author

dmitshur commented Feb 12, 2024 •
edited

Resumed the tagging workflow, it's working as expected:

[...]
2024/02/12 23:01:52 Manual retry requested
2024/02/12 23:01:53 Checking if c5643e9baf7fed6936d70e3abf925f86fa895ca1 is green
2024/02/12 23:01:54 skipping x_tools-gotip-linux-arm because of known issue 65241
2024/02/12 23:01:54 skipping x_tools-go1.22-linux-amd64-perf_vs_gopls_0_11 because of custom mode 4
2024/02/12 23:01:54 skipping x_tools-go1.22-linux-arm because of known issue 65241
2024/02/12 23:01:54 skipping x_tools-go1.21-linux-arm because of known issue 65241
2024/02/12 23:01:54 skipping x_tools-go1.21-linux-amd64-perf_vs_gopls_0_11 because of custom mode 4
2024/02/12 23:01:55 x_tools-go1.18-linux-amd64: found successful builds: [8756260958551880337]
[...]

The expected builders are being skipped for the right reasons, and there are no unexpected skips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmitshur dmitshur

Labels
Builders x/build issues (builders, bots, dashboards) FixPending Issues that have a fix which has not yet been reviewed or submitted. NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot