-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/cgo: can't run mkall.sh on tip, works in Go 1.1.2 #6558
Labels
Milestone
Comments
bisected it. hg says: Changeset 18077:46fd4ef6c0de: bad Due to skipped revisions, the first bad revision could be any of: changeset: 18074:7e10c412efea user: Russ Cox <rsc@golang.org> date: Wed Sep 11 09:56:51 2013 -0400 summary: cmd/cgo: don't say "gcc produced no output" if we ran clang changeset: 18075:e176e9d59540 user: Russ Cox <rsc@golang.org> date: Wed Sep 11 09:57:05 2013 -0400 summary: cmd/go: use pattern to prune file tree walk changeset: 18076:1b195d6fe342 user: Mikio Hara <mikioh.mikioh@gmail.com> date: Wed Sep 11 10:48:53 2013 -0400 summary: net: implement TCP connection setup with fast failover changeset: 18077:46fd4ef6c0de user: Russ Cox <rsc@golang.org> date: Wed Sep 11 11:30:08 2013 -0400 summary: cmd/cgo: replace C.malloc with our own wrapper had to skip revisions due to this compile error: cmd/cgo/gcc.go:386: undefined: fixGo cmd/cgo/gcc.go:596: undefined: fixGo cmd/cgo/gcc.go:607: undefined: fixGo cmd/cgo/gcc.go:656: undefined: fixGo cmd/cgo/gcc.go:660: undefined: fixGo cmd/cgo/gcc.go:666: undefined: fixGo I can confirm that revision 18073:7727c1ad5ba5 works. By revision 18077:46fd4ef6c0de it was broken. my bisect script for posterity: #!/bin/bash set -xe export GOROOT=$HOME/go export PATH=$GOROOT/bin:$PATH export GOOS=linux export GOARCH=amd64 export GOHOSTARCH=amd64 export GOOSARCH=$GOOS_$GOARCH cd $GOROOT hg revert --all hg purge hg identify cd $GOROOT/src ./make.bash || exit 125 go version || exit 125 cd $GOROOT/src/pkg/syscall set +e go tool cgo -godefs types_$GOOS.go >ztypes_$GOOSARCH.go EXIT=$? hg revert --all exit $EXIT |
it might be two different problems. the 1: error lines are probably from mkerrors.sh and the types_linux.go lines are from go tool cgo. the mkerrors failure is mysterious. the go tool cgo failure might just be a missing #include. however, neither is explained by the range of CLs you found. |
The problem is caused by this change: const builtinProlog = ` +#include <sys/types.h> /* for size_t below */ sys/types.h gets included without these defines: #define _LARGEFILE_SOURCE #define _LARGEFILE64_SOURCE #define _FILE_OFFSET_BITS 64 #define _GNU_SOURCE and later again with them, but I'm guessing at that point the include guards prevent these from having any effect. |
This issue was closed by revision 5feb155. Status changed to Fixed. |
This issue was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The text was updated successfully, but these errors were encountered: