Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/trace/v2: goroutine analysis page doesn't identify goroutines consistently [1.21 backport] #65576

Closed
gopherbot opened this issue Feb 7, 2024 · 2 comments
Closed

cmd/trace/v2: goroutine analysis page doesn't identify goroutines consistently [1.21 backport] #65576

gopherbot opened this issue Feb 7, 2024 · 2 comments
Milestone
Go1.21.8

Comments

@gopherbot
Copy link

@mknyszek requested issue #65574 to be considered for backport to the next 1.21 minor release.

@gopherbot Please open backport issues for Go 1.21 and Go 1.22. This makes the cmd/trace UI harder to interpret with no easy workaround. The fix is very safe because it only touches debug tooling, specifically go tool trace, not any Go code someone would run in production.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 7, 2024
@gopherbot gopherbot mentioned this issue Feb 7, 2024
Closed
@gopherbot gopherbot added this to the Go1.21.8 milestone Feb 7, 2024
@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label Feb 7, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 7, 2024
@nsrip-dd
Copy link
Contributor

nsrip-dd commented Feb 8, 2024

@mknyszek I don't think a backport is needed for Go 1.21. Execution traces for Go 1.21 and earlier give the first event for a goroutine a one-frame stack trace containing the starting PC for the goroutine. So, even if the Go 1.21 code is reading the wrong end of the stack when determining the name/starting PC of a goroutine, there's only one frame so it works as intended.

@mknyszek
Copy link
Contributor

mknyszek commented Feb 8, 2024

Ah, oops. Thank you. That was just muscle memory.

@mknyszek mknyszek closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2024
@dmitshur dmitshur removed the CherryPickApproved Used during the release process for point releases label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Go1.21.8
Development

No branches or pull requests
5 participants
@mknyszek @dmitshur @dr2chase @gopherbot @nsrip-dd