Skip to content

x/telemetry/cmd/gotelemetry: view/dump commands fail to aggregate crash/crash stack counts #65554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hyangah opened this issue Feb 6, 2024 · 1 comment
Labels
FrozenDueToAge telemetry x/telemetry issues
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented Feb 6, 2024

I don't know why, but the new crash/crash counter values don't seem to get aggregated as one counter value in gotelemetry's view/dump reports.

Screenshot 2024-02-06 at 2 24 43 PM
$ gotelemetry dump 
...
-- .../go/telemetry/local/gopls@devel-devel-darwin-amd64-2024-02-05.v1.count --
{
	"Meta": {
		"GOARCH": "amd64",
		"GOOS": "darwin",
		"GoVersion": "devel",
		"Program": "golang.org/x/tools/gopls",
		"TimeBegin": "2024-02-05T00:00:00Z",
		"TimeEnd": "2024-02-08T00:00:00Z",
		"Version": "devel"
	},
	"Count": {
		"counter/main": 2,
		"crash/crash\nruntime.gopanic:59\nruntime.panicmem:?261\ngo/ast.Walk:184\ngo/ast.Inspect:?397\ngolang.org/x/tools/gopls/internal/golang.highlightPath:29\ngolang.org/x/tools/gopls/internal/golang.Highlight:31\ngolang.org/x/tools/gopls/internal/server.(*server).DocumentHighlight:14\ngolang.org/x/tools/gopls/internal/protocol.serverDispatch:280\ngolang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:5\ngolang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:52\ngolang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:2\ngolang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:3\nruntime.goexit:0": 3,
		"crash/crash\nruntime.gopanic:59\nruntime.panicmem:?261\ngo/ast.Walk:184\ngo/ast.Inspect:?397\ngolang.org/x/tools/gopls/internal/golang.highlightPath:32\ngolang.org/x/tools/gopls/internal/golang.Highlight:31\ngolang.org/x/tools/gopls/internal/server.(*server).DocumentHighlight:14\ngolang.org/x/tools/gopls/internal/protocol.serverDispatch:280\ngolang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:5\ngolang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:52\ngolang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:2\ngolang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:3\nruntime.goexit:0": 9,
		"gopls/client:coc.nvim": 1,
		"gopls/client:other": 1,
		"gopls/client:vscode": 14,
		"gopls/completion/latency:\u003c100ms": 153,
		"gopls/completion/latency:\u003c10ms": 1031,
		"gopls/completion/latency:\u003c1s": 2,
		"gopls/completion/latency:\u003c200ms": 2920,
		"gopls/completion/latency:\u003c500ms": 3,
		"gopls/completion/latency:\u003c50ms": 2572,
		"gopls/completion/latency:\u003c5s": 1,
		"gopls/definition/latency:\u003c10ms": 31,
		"gopls/definition/latency:\u003c1s": 1,
		"gopls/definition/latency:\u003c50ms": 2,
		"gopls/goversion:1.21": 23,
		"gopls/hover/error-latency:\u003c10ms": 14,
		"gopls/hover/latency:\u003c10ms": 354,
		"gopls/hover/latency:\u003c50ms": 1,
		"gopls/references/latency:\u003c10ms": 1
	}
}
@gopherbot gopherbot added the telemetry x/telemetry issues label Feb 6, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 6, 2024
@hyangah
Copy link
Contributor Author

hyangah commented Feb 6, 2024

Actually, they are two different stacks. 5th elements from the top are different. Closing.

@hyangah hyangah closed this as not planned Won't fix, can't repro, duplicate, stale Feb 6, 2024
@golang golang locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge telemetry x/telemetry issues
Projects
None yet
Development

No branches or pull requests

2 participants