Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite/cmd/pkgsite: tests consistently failing with TempDir RemoveAll cleanup errors on windows as of CL 559615 #65545

Closed
bcmills opened this issue Feb 6, 2024 · 1 comment
Closed

x/pkgsite/cmd/pkgsite: tests consistently failing with TempDir RemoveAll cleanup errors on windows as of CL 559615 #65545

bcmills opened this issue Feb 6, 2024 · 1 comment
Labels
OS-Windows Soon This needs to be done soon. (regressions, serious bugs, outages)
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 6, 2024

Go version

6f44cc8

Output of go env in your module/workspace:

N/A

What did you do?

https://build.golang.org/log/292d4f122d2f2eab97f2bc7e5c07570c4311f17f

What did you see happen?

--- FAIL: TestServer (6.89s)
    testing.go:1231: TempDir RemoveAll cleanup: remove C:\Users\gopher\AppData\Local\Temp\1\TestServer2537943436\001: The process cannot access the file because it is being used by another process.
FAIL
FAIL	golang.org/x/pkgsite/cmd/pkgsite	7.092s

What did you expect to see?

All tests should be passing.

I think this is just a missed Closed call on a file opened in extractReadme.
@bcmills bcmills added OS-Windows Soon This needs to be done soon. (regressions, serious bugs, outages) labels Feb 6, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 6, 2024
This was referenced Feb 6, 2024
Open
Open
@gopherbot
Copy link

Change https://go.dev/cl/562176 mentions this issue: internal/fetch: close directory file in defer in extractReadme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OS-Windows Soon This needs to be done soon. (regressions, serious bugs, outages)
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot