Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: missing diagnostics in GOROOT #65481

Closed
findleyr opened this issue Feb 2, 2024 · 2 comments
Closed

x/tools/gopls: missing diagnostics in GOROOT #65481

findleyr opened this issue Feb 2, 2024 · 2 comments
Assignees
@findleyr
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.15.0

Comments

@findleyr
Copy link
Contributor

findleyr commented Feb 2, 2024

It has clearly been a while since I worked in GOROOT... It appears that the zero config changes in #57979 have broken diagnostic reporting in GOROOT. Navigation, completion works, but I'm not getting diagnostics.

This needs fixing (of course) before gopls@v0.15.0.
@findleyr findleyr added this to the gopls/v0.15.0 milestone Feb 2, 2024
@findleyr findleyr self-assigned this Feb 2, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 2, 2024
@findleyr
Copy link
Contributor Author

findleyr commented Feb 2, 2024

Oh, it was because I had a go.work file in rather than <repo root>/src. Moving my go.work file into src/ works. Ok, marking as WAI.

CC @matloob -- I'm not sure why I had a go.work file in <repo root>, but did this ever work?

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Feb 2, 2024
@matloob
Copy link
Contributor

matloob commented Feb 5, 2024

Off the top of my head I can't think of a reason why <repo root> would work differently from it being in <src>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@findleyr findleyr

Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.15.0
Development

No branches or pull requests
3 participants
@gopherbot @matloob @findleyr