Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/ipv6: does not compile with go1.1 #6548

Closed
gopherbot opened this issue Oct 8, 2013 · 13 comments
Closed

x/net/ipv6: does not compile with go1.1 #6548

gopherbot opened this issue Oct 8, 2013 · 13 comments
Labels
FrozenDueToAge

Comments

@gopherbot
Copy link

by CantStopTheSignals:

What steps will reproduce the problem?
1. import "code.google.com/p/go.net/websocket"
2. go install all


What is the expected output?

Compilation should succeed


What do you see instead?

# code.google.com/p/go.net/ipv6
code.google.com/p/go.net/ipv6/icmp.go:30: defer requires function call, not conversion
code.google.com/p/go.net/ipv6/icmp.go:37: defer requires function call, not conversion
code.google.com/p/go.net/ipv6/icmp.go:44: defer requires function call, not conversion
code.google.com/p/go.net/ipv6/icmp_bsd.go:12: undefined: syscall.ICMPv6Filter
code.google.com/p/go.net/ipv6/sockopt_rfc2292_darwin.go:57: undefined:
syscall.GetsockoptICMPv6Filter
code.google.com/p/go.net/ipv6/sockopt_rfc2292_darwin.go:57: undefined:
syscall.ICMP6_FILTER
code.google.com/p/go.net/ipv6/sockopt_rfc2292_darwin.go:65: undefined:
syscall.SetsockoptICMPv6Filter
code.google.com/p/go.net/ipv6/sockopt_rfc2292_darwin.go:65: undefined:
syscall.ICMP6_FILTER


Which compiler are you using (5g, 6g, 8g, gccgo)?

Default compiler for go1.1.2 on mac osx


Which operating system are you using?

mac osx 10.8.5


Which version are you using?  (run 'go version')

go version go1.1.2 darwin/386

Please provide any additional information below.
@gopherbot
Copy link
Author

Comment 1 by CantStopTheSignals:

Sorry for the confusion. While the compilation does fail if I use go install all, if I
only install my own package (and only import websockets), the compilation does succeed.

@mikioh
Copy link
Contributor

mikioh commented Oct 9, 2013

Comment 2:

Yup, unfortunately. Just re-checked go.net and got the following:
              go1.0     go1.1     go1.2
dict          ok        ok        ok
html          --        ok        ok
idna          ok        ok        ok
ipv4          --        ok        ok
ipv6          --        --        ok
netutil       ok        ok        ok
proxy         ok        ok        ok
publixsuffix  --        ok        ok
spdy          ok        ok        ok
websocket     ok        ok        ok
I'm guessing only thing we can do for now is just adding tags go1.1 or go1.2 to source
code and making non-workable binary stuff instead of displaying build failures. Ah, but
I'm not sure how could we handle this issue on app engine.

@mikioh
Copy link
Contributor

mikioh commented Oct 16, 2013

Comment 3:

I have no clue for this kind of stuff: what's the best way to manage packages in sub
repositories.
FYI: https://groups.google.com/d/msg/google-appengine-go/gvlUWl1A0b0/ywuKM6XONgIJ

Status changed to HelpWanted.

@ianlancetaylor
Copy link
Contributor

Comment 4:

Where possible, change the code to work with Go 1.  Where that is not possible, use
build tags to separate out code that only builds with Go 1.2.

@dsymonds
Copy link
Contributor

Comment 5:

Go 1.1 seems like it has been out long enough that we don't need to expend significant
effort to support anything earlier. We should definitely support Go 1.1 though, since
today that is the stable release, and we need to give folk enough time after the Go 1.2
release to migrate to that.
What parts of go.net/ipv6 don't work on Go 1.1? If it's only a small part of that
package we should stub them out.

@mikioh
Copy link
Contributor

mikioh commented Oct 17, 2013

Comment 6:

If we can agree only focusing on Go 1.1, keeping own system adaptation stuff ported from
syscall will be a fix, probably.

@mikioh
Copy link
Contributor

mikioh commented Oct 17, 2013

Comment 7:

> We should definitely support Go 1.1 though
Seems like the bar has been raised. ;) But I agree with you. This issue and the thread
on google-appengine-go are the evidences. I'll try tweaks relates #6 this weekend unless
more better solution comes up.

@wcn3
Copy link

wcn3 commented Oct 22, 2013

Comment 8:

https://golang.org/cl/15460044 fixes it up for Darwin. If this looks
acceptable, I can continue for BSD variants.

@mikioh
Copy link
Contributor

mikioh commented Oct 22, 2013

Comment 9:

Thanks but I also have https://golang.org/cl/15040044/

Status changed to Accepted.

@mikioh
Copy link
Contributor

mikioh commented Nov 3, 2013

Comment 11:

Labels changed: added priority-soon, removed priority-triage.

Owner changed to @mikioh.

Status changed to Started.

@mikioh
Copy link
Contributor

mikioh commented Nov 5, 2013

Comment 12:

This issue was updated by revision golang/net@d3003be.

R=dave, dsymonds, adg
CC=golang-dev
https://golang.org/cl/19940044

@mikioh
Copy link
Contributor

mikioh commented Nov 5, 2013

Comment 13:

Issue #6164 has been merged into this issue.

@mikioh
Copy link
Contributor

mikioh commented Nov 6, 2013

Comment 14:

This issue was closed by revision golang/net@b27e68b.

Status changed to Fixed.

@mikioh mikioh added repo-net and removed repo-net labels Dec 23, 2014
@mikioh mikioh changed the title go.net/ipv6: does not compile with go1.1 ipv6: does not compile with go1.1 Jan 4, 2015
@mikioh mikioh changed the title ipv6: does not compile with go1.1 x/net/ipv6: does not compile with go1.1 Jul 20, 2015
@golang golang locked and limited conversation to collaborators Jul 20, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@dsymonds @mikioh @ianlancetaylor @wcn3 @gopherbot