Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/testenv: support LUCI mobile builders in testenv tests [1.22 backport] #65474

Closed
gopherbot opened this issue Feb 2, 2024 · 3 comments
Closed

internal/testenv: support LUCI mobile builders in testenv tests [1.22 backport] #65474

gopherbot opened this issue Feb 2, 2024 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.22.1

Comments

@gopherbot
Copy link

@mknyszek requested issue #65473 to be considered for backport to the next 1.20 minor release.

@gopherbot Please create backport issues. The fix is test-only and will make setting up LUCI mobile platform builders just a little bit easier in the future.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 2, 2024
@gopherbot gopherbot mentioned this issue Feb 2, 2024
Closed
@gopherbot gopherbot added this to the Go1.20.14 milestone Feb 2, 2024
@mknyszek
Copy link
Contributor

mknyszek commented Feb 2, 2024

Hijacking this issue for Go 1.22.1. Since Go 1.20 is going to be dropped from support imminently, I don't think we need to backport it there.

@mknyszek mknyszek changed the title internal/testenv: support LUCI mobile builders in testenv tests [1.20 backport] internal/testenv: support LUCI mobile builders in testenv tests [1.22 backport] Feb 2, 2024
@mknyszek mknyszek modified the milestones: Go1.20.14, Go1.22.1 Feb 2, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/560536 mentions this issue: [release-branch.go1.22] internal/testenv: support the LUCI mobile builders in tests

@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. CherryPickApproved Used during the release process for point releases and removed CherryPickCandidate Used during the release process for point releases labels Feb 2, 2024
gopherbot pushed a commit that referenced this issue Feb 8, 2024
@mknyszek
[release-branch.go1.22] internal/testenv: support the LUCI mobile bui…
20107e0 
…lders in tests

This change updates the testenv tests to correctly match on future LUCI
builder names for mobile builders. This isn't a problem today because
those haven't been set up yet, but the builder names are structured and
it's clear where the modifiers will appear. Might as well set them up
now.

For #65473.
Fixes #65474.

Change-Id: I244b88a62a90312c0f3ff2360527d58531070362
Reviewed-on: https://go-review.googlesource.com/c/go/+/558597
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 5c7c24c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/560536
@gopherbot
Copy link
Author

Closed by merging 20107e0 to release-branch.go1.22.

bradfitz pushed a commit to tailscale/go that referenced this issue Mar 5, 2024
@mknyszek @bradfitz
[release-branch.go1.22] internal/testenv: support the LUCI mobile bui…
b412da5 
…lders in tests

This change updates the testenv tests to correctly match on future LUCI
builder names for mobile builders. This isn't a problem today because
those haven't been set up yet, but the builder names are structured and
it's clear where the modifiers will appear. Might as well set them up
now.

For golang#65473.
Fixes golang#65474.

Change-Id: I244b88a62a90312c0f3ff2360527d58531070362
Reviewed-on: https://go-review.googlesource.com/c/go/+/558597
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 5c7c24c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/560536
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 6, 2024
@mknyszek @romaindoumenc
[release-branch.go1.22] internal/testenv: support the LUCI mobile bui…
2b56eff 
…lders in tests

This change updates the testenv tests to correctly match on future LUCI
builder names for mobile builders. This isn't a problem today because
those haven't been set up yet, but the builder names are structured and
it's clear where the modifiers will appear. Might as well set them up
now.

For golang#65473.
Fixes golang#65474.

Change-Id: I244b88a62a90312c0f3ff2360527d58531070362
Reviewed-on: https://go-review.googlesource.com/c/go/+/558597
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 5c7c24c)
Reviewed-on: https://go-review.googlesource.com/c/go/+/560536
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.22.1
Development

No branches or pull requests
3 participants
@mknyszek @dmitshur @gopherbot