Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/testenv: TestHasGoBuild failures on the LUCI noopt builders [1.22 backport] #65471

Closed
gopherbot opened this issue Feb 2, 2024 · 3 comments
Closed

internal/testenv: TestHasGoBuild failures on the LUCI noopt builders [1.22 backport] #65471

gopherbot opened this issue Feb 2, 2024 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.22.1

Comments

@gopherbot
Copy link

@mknyszek requested issue #65470 to be considered for backport to the next 1.20 minor release.

@gopherbot Please open backport issues. This issue should be fixed as it means the LUCI noopt builder consistently fails on release branches. The fix is test-only, so very safe.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 2, 2024
@gopherbot gopherbot mentioned this issue Feb 2, 2024
Closed
@gopherbot gopherbot added this to the Go1.20.14 milestone Feb 2, 2024
@mknyszek
Copy link
Contributor

mknyszek commented Feb 2, 2024

Hijacking this issue for Go 1.22.1. Since Go 1.20 is going to be dropped from support imminently, I don't think we need to backport it there.

@mknyszek mknyszek changed the title internal/testenv: TestHasGoBuild failures on the LUCI noopt builders [1.20 backport] internal/testenv: TestHasGoBuild failures on the LUCI noopt builders [1.22 backport] Feb 2, 2024
@mknyszek mknyszek modified the milestones: Go1.20.14, Go1.22.1 Feb 2, 2024
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Feb 2, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/560696 mentions this issue: [release-branch.go1.22] internal/testenv: allow "-noopt" anywhere in builder name in test

@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label Feb 7, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 7, 2024
gopherbot pushed a commit that referenced this issue Feb 8, 2024
@mknyszek
[release-branch.go1.22] internal/testenv: allow "-noopt" anywhere in …
53d1b73 
…builder name in test

testenv's TestHasGoBuild test is supposed to allow noopt builders to not
have go build, but the pattern match is failing on the LUCI builders
where a test shard might have an additional "-test_only" suffix in the
builder name. Furthermore, in the LUCI world, "run mods" (the builder
type suffixes) are supposed to be well-defined and composable, so it
doesn't make sense to restrict "-noopt" to the builder suffix anyway.

This change modifies the test to allow "-noopt" to appear anywhere in
the builder name when checking if it's running on a noopt builder.

For #65470.
Fixes #65471.

Change-Id: I393818e3e8e452c7b0927cbc65726d552aa8ff8e
Reviewed-on: https://go-review.googlesource.com/c/go/+/558596
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 93f0c0b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/560696
@gopherbot
Copy link
Author

Closed by merging 53d1b73 to release-branch.go1.22.

bradfitz pushed a commit to tailscale/go that referenced this issue Mar 5, 2024
@mknyszek @bradfitz
[release-branch.go1.22] internal/testenv: allow "-noopt" anywhere in …
e906022 
…builder name in test

testenv's TestHasGoBuild test is supposed to allow noopt builders to not
have go build, but the pattern match is failing on the LUCI builders
where a test shard might have an additional "-test_only" suffix in the
builder name. Furthermore, in the LUCI world, "run mods" (the builder
type suffixes) are supposed to be well-defined and composable, so it
doesn't make sense to restrict "-noopt" to the builder suffix anyway.

This change modifies the test to allow "-noopt" to appear anywhere in
the builder name when checking if it's running on a noopt builder.

For golang#65470.
Fixes golang#65471.

Change-Id: I393818e3e8e452c7b0927cbc65726d552aa8ff8e
Reviewed-on: https://go-review.googlesource.com/c/go/+/558596
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 93f0c0b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/560696
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 6, 2024
@mknyszek @romaindoumenc
[release-branch.go1.22] internal/testenv: allow "-noopt" anywhere in …
4a40e26 
…builder name in test

testenv's TestHasGoBuild test is supposed to allow noopt builders to not
have go build, but the pattern match is failing on the LUCI builders
where a test shard might have an additional "-test_only" suffix in the
builder name. Furthermore, in the LUCI world, "run mods" (the builder
type suffixes) are supposed to be well-defined and composable, so it
doesn't make sense to restrict "-noopt" to the builder suffix anyway.

This change modifies the test to allow "-noopt" to appear anywhere in
the builder name when checking if it's running on a noopt builder.

For golang#65470.
Fixes golang#65471.

Change-Id: I393818e3e8e452c7b0927cbc65726d552aa8ff8e
Reviewed-on: https://go-review.googlesource.com/c/go/+/558596
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 93f0c0b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/560696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.22.1
Development

No branches or pull requests
4 participants
@mknyszek @dmitshur @dr2chase @gopherbot