Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/testenv: TestHasGoBuild failures on the LUCI noopt builders #65470

Closed
mknyszek opened this issue Feb 2, 2024 · 4 comments
Closed

internal/testenv: TestHasGoBuild failures on the LUCI noopt builders #65470

mknyszek opened this issue Feb 2, 2024 · 4 comments
Assignees
@mknyszek
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.22

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Feb 2, 2024

I fixed this issue on tip (https://go.dev/cl/558596), but forgot to backport the fix.
@mknyszek mknyszek self-assigned this Feb 2, 2024
@mknyszek mknyszek added this to the Go1.22 milestone Feb 2, 2024
@mknyszek
Copy link
Contributor Author

mknyszek commented Feb 2, 2024

@gopherbot Please open backport issues. This issue should be fixed as it means the LUCI noopt builder consistently fails on release branches. The fix is test-only, so very safe.

@gopherbot gopherbot mentioned this issue Feb 2, 2024
Closed
@gopherbot
Copy link

Backport issue(s) opened: #65471 (for 1.20), #65472 (for 1.21).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

@gopherbot gopherbot mentioned this issue Feb 2, 2024
Closed
@mknyszek mknyszek closed this as completed Feb 2, 2024
@gopherbot
Copy link

Change https://go.dev/cl/560696 mentions this issue: [release-branch.go1.22] internal/testenv: allow "-noopt" anywhere in builder name in test

@gopherbot
Copy link

Change https://go.dev/cl/560518 mentions this issue: [release-branch.go1.21] internal/testenv: allow "-noopt" anywhere in builder name in test

@mknyszek mknyszek mentioned this issue Feb 2, 2024
Closed
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Feb 2, 2024
gopherbot pushed a commit that referenced this issue Feb 8, 2024
@mknyszek
[release-branch.go1.22] internal/testenv: allow "-noopt" anywhere in …
53d1b73 
…builder name in test

testenv's TestHasGoBuild test is supposed to allow noopt builders to not
have go build, but the pattern match is failing on the LUCI builders
where a test shard might have an additional "-test_only" suffix in the
builder name. Furthermore, in the LUCI world, "run mods" (the builder
type suffixes) are supposed to be well-defined and composable, so it
doesn't make sense to restrict "-noopt" to the builder suffix anyway.

This change modifies the test to allow "-noopt" to appear anywhere in
the builder name when checking if it's running on a noopt builder.

For #65470.
Fixes #65471.

Change-Id: I393818e3e8e452c7b0927cbc65726d552aa8ff8e
Reviewed-on: https://go-review.googlesource.com/c/go/+/558596
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 93f0c0b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/560696
gopherbot pushed a commit that referenced this issue Feb 8, 2024
@mknyszek
[release-branch.go1.21] internal/testenv: allow "-noopt" anywhere in …
f997dfd 
…builder name in test

testenv's TestHasGoBuild test is supposed to allow noopt builders to not
have go build, but the pattern match is failing on the LUCI builders
where a test shard might have an additional "-test_only" suffix in the
builder name. Furthermore, in the LUCI world, "run mods" (the builder
type suffixes) are supposed to be well-defined and composable, so it
doesn't make sense to restrict "-noopt" to the builder suffix anyway.

This change modifies the test to allow "-noopt" to appear anywhere in
the builder name when checking if it's running on a noopt builder.

For #65470.
Fixes #65472.

Change-Id: I393818e3e8e452c7b0927cbc65726d552aa8ff8e
Reviewed-on: https://go-review.googlesource.com/c/go/+/558596
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 93f0c0b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/560518
bradfitz pushed a commit to tailscale/go that referenced this issue Mar 5, 2024
@mknyszek @bradfitz
[release-branch.go1.22] internal/testenv: allow "-noopt" anywhere in …
e906022 
…builder name in test

testenv's TestHasGoBuild test is supposed to allow noopt builders to not
have go build, but the pattern match is failing on the LUCI builders
where a test shard might have an additional "-test_only" suffix in the
builder name. Furthermore, in the LUCI world, "run mods" (the builder
type suffixes) are supposed to be well-defined and composable, so it
doesn't make sense to restrict "-noopt" to the builder suffix anyway.

This change modifies the test to allow "-noopt" to appear anywhere in
the builder name when checking if it's running on a noopt builder.

For golang#65470.
Fixes golang#65471.

Change-Id: I393818e3e8e452c7b0927cbc65726d552aa8ff8e
Reviewed-on: https://go-review.googlesource.com/c/go/+/558596
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 93f0c0b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/560696
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 6, 2024
@mknyszek @romaindoumenc
[release-branch.go1.22] internal/testenv: allow "-noopt" anywhere in …
4a40e26 
…builder name in test

testenv's TestHasGoBuild test is supposed to allow noopt builders to not
have go build, but the pattern match is failing on the LUCI builders
where a test shard might have an additional "-test_only" suffix in the
builder name. Furthermore, in the LUCI world, "run mods" (the builder
type suffixes) are supposed to be well-defined and composable, so it
doesn't make sense to restrict "-noopt" to the builder suffix anyway.

This change modifies the test to allow "-noopt" to appear anywhere in
the builder name when checking if it's running on a noopt builder.

For golang#65470.
Fixes golang#65471.

Change-Id: I393818e3e8e452c7b0927cbc65726d552aa8ff8e
Reviewed-on: https://go-review.googlesource.com/c/go/+/558596
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
(cherry picked from commit 93f0c0b)
Reviewed-on: https://go-review.googlesource.com/c/go/+/560696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mknyszek mknyszek

Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.22
Development

No branches or pull requests
3 participants
@mknyszek @dmitshur @gopherbot