Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/gorename: TestGeneratedFiles failures #65462

Closed
gopherbot opened this issue Feb 2, 2024 · 3 comments
Closed

x/tools/cmd/gorename: TestGeneratedFiles failures #65462

gopherbot opened this issue Feb 2, 2024 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/cmd/gorename" && test == "TestGeneratedFiles"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestGeneratedFiles
    gorename_test.go:334: Building gorename: exit status 1
        error obtaining VCS status: exit status 128
        	Use -buildvcs=false to disable VCS stamping.
--- FAIL: TestGeneratedFiles (1.49s)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 2, 2024
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Feb 2, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 2, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/cmd/gorename" && test == "TestGeneratedFiles"
2024-02-01 23:36 x_tools-gotip-windows-amd64-race tools@d0778885 go@149db960 x/tools/cmd/gorename.TestGeneratedFiles (log) 
=== RUN   TestGeneratedFiles
    gorename_test.go:334: Building gorename: exit status 1
        error obtaining VCS status: exit status 128
        	Use -buildvcs=false to disable VCS stamping.
--- FAIL: TestGeneratedFiles (1.49s)

— watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/cmd/gorename" && test == "TestGeneratedFiles"
2024-08-13 17:53 x_tools-gotip-linux-riscv64 tools@7cc3be7d go@1419d0e9 x/tools/cmd/gorename.TestGeneratedFiles (log) 
=== RUN   TestGeneratedFiles
    gorename_test.go:286: 9: -from "\"test\".Foo" -to "Bar": received unexpected error exit status 2
    gorename_test.go:290: 9: -from "\"test\".Foo" -to "Bar": unexpected command output: SIGSEGV: segmentation violation
        PC=0x516b8 m=2 sigcode=1 addr=0xc0
        
        goroutine 0 gp=0x3f6c000a80 m=2 mp=0x3f6c054708 [idle]:
        runtime.preemptone(0x3f6c000a80?)
        	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/proc.go:6310 +0x38 fp=0x3f6c06ff28 sp=0x3f6c06ff10 pc=0x516b8
        runtime.preemptall()
        	/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/proc.go:6288 +0x60 fp=0x3f6c06ff50 sp=0x3f6c06ff28 pc=0x51658
...
        a7  0x5d24	s2  0x3f6c06fed0
        s3  0x3f6c054708	s4  0x3f6c060000
        s5  0x36	s6  0x65
        s7  0x4	s8  0x3f6c0386b0
        s9  0x3f6c06ffa0	s10 0x26f730
        s11 0x3f6c000a80	t3  0x3295f146b592fc
        t4  0xffffffffffffffff	t5  0x854304b281
        t6  0x1	pc  0x516b8
         (want: Renamed 2 occurrences in 2 files in 2 packages.)
--- FAIL: TestGeneratedFiles (55.15s)

— watchflakes

@seankhliao
Copy link
Member

closing as obsoleted by #69360

@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @seankhliao