Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/integration/watch: TestSwitchFromGOPATHToModuleMode/default failures #65460

Open
gopherbot opened this issue Feb 2, 2024 · 3 comments
Open

x/tools/gopls/internal/test/integration/watch: TestSwitchFromGOPATHToModuleMode/default failures #65460

gopherbot opened this issue Feb 2, 2024 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.16.0

Comments

@gopherbot
Copy link 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/watch" && test == "TestSwitchFromGOPATHToModuleMode/default"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestSwitchFromGOPATHToModuleMode/default
DETECTED A HANGING GO COMMAND

The gopls test runner has detected a hanging go command. In order to debug
this, the output of ps and lsof/fstat is printed below.

See golang/go#54461 for more details.

ps axo ppid,pid,command:
-------------------------
...
      1 4184421 [asm] <defunct>
      1 4185715 [compile] <defunct>
      1 4190463 [compile] <defunct>
      1 4190464 [compile] <defunct>
      1 4190465 [compile] <defunct>
      1 4190466 [compile] <defunct>

lsof:
-----
--- FAIL: TestSwitchFromGOPATHToModuleMode/default (70.91s)

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 2, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 2, 2024
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/watch" && test == "TestSwitchFromGOPATHToModuleMode/default"
2024-01-31 21:44 x_tools-go1.21-linux-ppc64le tools@5f906919 release-branch.go1.21@916e6cdd x/tools/gopls/internal/test/integration/watch.TestSwitchFromGOPATHToModuleMode/default (log) 
=== RUN   TestSwitchFromGOPATHToModuleMode/default
DETECTED A HANGING GO COMMAND

The gopls test runner has detected a hanging go command. In order to debug
this, the output of ps and lsof/fstat is printed below.

See golang/go#54461 for more details.

ps axo ppid,pid,command:
-------------------------
...
      1 4184421 [asm] <defunct>
      1 4185715 [compile] <defunct>
      1 4190463 [compile] <defunct>
      1 4190464 [compile] <defunct>
      1 4190465 [compile] <defunct>
      1 4190466 [compile] <defunct>

lsof:
-----
--- FAIL: TestSwitchFromGOPATHToModuleMode/default (70.91s)

— watchflakes

@findleyr
Copy link
Contributor

findleyr commented Feb 6, 2024

Hmm, hanging Go command. @bcmills does the output here indicate anything?

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.16.0 Feb 7, 2024
@bcmills
Copy link
Contributor

bcmills commented Feb 7, 2024

Unfortunately it doesn't even include the PID of the command, because it hit a panic due to a missing lsof command:
https://cs.opensource.google/go/x/tools/+/master:internal/gocommand/invoke.go;l=439;drc=f60f2e6aa42c945111053771ea53938694791d83

Probably we should just print those errors instead of panicking on them, since we're going to panic later due to the hang anyway. 😅

That said, given #65171 I wonder if this builder machine is just slow and/or overloaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: No status
Milestone
gopls/v0.16.0
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @findleyr