x/build: adding LUCI builders blocking submit is too manual #65439
Labels
Builders
x/build issues (builders, bots, dashboards)
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Comments
mknyszek
added
the
NeedsInvestigation
|
Agreed that this is annoying and a regression from previous behavior. I found a relevant upstream issue and posted to it: https://crbug.com/1498511. This is something we may be able to improve ourselves with some guidance and/or input from the LUCI team. (Personally, I would really love to also take advantage of the idea in https://crbug.com/1498511 to shrink the Choose Tryjobs list, if possible. I have a planned workaround, but it's kind of a hack.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Go version
N/A
Output of
go envin your module/workspace:What did you do?
Review contributed changes that need additional testing (such as running on a
longtestbuilder or a particular architecture) before they can be safely merged.What did you see happen?
There is a “CHOOSE TRYJOBS” button, but IIRC it doesn't affect auto-submit, and it definitely doesn't stick when a new patchset is uploaded.
It is possible to leave a comment requesting that the author add a
Cq-Include-Trybots:line to the commit message, but for small externally-contributed changes that can add an extra round-trip.What did you expect to see?
Some way that I (as a reviewer) can mark the CL as ok to auto-submit provided that a specific set of additional LUCI builders succeeds.
The text was updated successfully, but these errors were encountered: