-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: add LUCI linux-loong64 builder #65398
Comments
Thanks for working on this! |
I'm on rotation so I'll try to get to this this week. |
Does anyone know offhand if this is a slower-than-usual builder? (I'm on rotation this week, in the middle of doing the addition.) |
and it does have network access? |
@dr2chase The
|
Change https://go.dev/cl/561339 mentions this issue: |
For golang/go#65398. Change-Id: Ideeea51070055f154b8720ee811dd43563b544ec Reviewed-on: https://go-review.googlesource.com/c/build/+/561339 Reviewed-by: Michael Knyszek <mknyszek@google.com> TryBot-Bypass: Michael Knyszek <mknyszek@google.com>
I haven't fully configured loong64's builder yet, and some additional settings may be needed for the builder to work properly. |
The certificate you provided, it is for "linux-loong64-builder", could it instead be for "linux-loong64"? That would match the pattern for all the other builders. Thanks much, sorry for the hiccup, no rush if you are enjoying your vacation. |
This is the certificate I regenerated using hostname "linux-loong64". Please replace linux-loong64-builder.csr.txt with the current linux-loong64.csr.txt. Thanks |
Gentle ping. |
Thank you for the certificate. I've tried to launch the swarming bot, but I came across this error:
Is there something I'm doing wrong? |
Can you access https://chromium-swarm.appspot.com/swarming/api/v1/bot/server_ping? That shouldn't require authentication or anything. It seems like there may be an issue with your network connection? |
Link https://chromium-swarm.appspot.com/swarming/api/v1/bot/server_ping I can access it normally, I try to curl the command to retrieve it and return This is the content of swarming_bot.log
Based on this https://go.dev/wiki/DashboardBuilders Network access requirements, links https://remotebuildexecution.googleapis.com I am unable to access it, everything else is fine |
@prattmic The problem is that I configured the proxy environment variables https_proxy and http_proxy, but swarming_bot did not use them, which caused the network to be inaccessible. I didn't see relevant prompt information in the documentation and code of swarming_bot, so I don't know how to configure it to make these environment variables take effect. |
I am not sure what is the correct way to configure a proxy for the swarming bot. The source code for the swarming bot is at https://source.chromium.org/chromium/infra/infra/+/main:luci/appengine/swarming/swarming_bot/bot_code/bot_main.py;l=1785;drc=0d534b7e80a34a79a114fa0a05e5e984190fdbf7 (this line is, I believe, where the I am not very familiar with this code, but digging down several layers to https://source.chromium.org/chromium/infra/infra/+/main:luci/client/utils/net.py;l=810;drc=f9002fe7a0ae6b2837c9c48112b87d820bff9ffa, it looks like this ultimately uses Python |
This problem has been confirmed, that is, swarming_bot does not support system environment variable settings. Someone has reported this problem here luci/luci-py#323. After I tried adding this CL, I can see the builder of loong64 at https://7419-34ac013-dot-chromium-swarm.appspot.com/bot?id=linux-loong64 Here are my changes:
|
I have enabled the system proxy environment settings and added Loong64 support to swarming-bot. CL: |
In Golang, the GOARCH defined for loongarch64 is loong64. Related links: golang/go#46229 golang/go#65398 Change-Id: Idd99c006e8c069f5936654bfafcccf4168f51876 Reviewed-on: https://chromium-review.googlesource.com/c/infra/luci/luci-py/+/5334945 Reviewed-by: Chan Li <chanli@chromium.org> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
@prattmic |
This error occurred while running the task: https://7419-34ac013-dot-chromium-swarm.appspot.com/task?id=685629cf2b55df10&w=true |
cc @golang/release |
I found the following error after the service ran for a while: But I have confirmed that the network is OK, Here is the detailed log: swarming_bot.log |
This problem seems to be happening again |
I am ready to connect multiple builders, but how can I distinguish the BOT_ID? The environment variable SWARMING_BOT_ID seems to be deprecated. |
Thanks, I know how to do this. |
Gentle ping. |
Can a task be triggered on this builder? If everything goes smoothly, I plan to take all the builders connected through the buildlet method offline and then switch them all to the LUCI access method Thanks. |
Friendly ping. @golang/release Can you solve this error? ( https://7419-34ac013-dot-chromium-swarm.appspot.com/task?id=68c4af6ef5417c10)? Thanks |
I'm working on resolving that error message. As soon as it is resolved, I will respond to this issue. Thanks for pushing this along. |
Gentle ping. |
We're still working on this on our side, and will update this after it's resolved or more progress is made. Thanks for your patience and for pushing this forward. |
Now the LUCI linux-loong64 builder can work happily. Of course, there are occasional network timeouts. Thanks! |
We are glad to hear that it's working now. Now that the builder is up and running, is there any reason we can't close this issue? Thank you for all of your work. |
Change https://go.dev/cl/584776 mentions this issue: |
The builder is up and working. There are occasional temporary network errors, but that can be improved upon separately. Fixes golang/go#65398. Change-Id: I91e9b1e96efd852b5394bd670dd52c421440e719 Reviewed-on: https://go-review.googlesource.com/c/build/+/584776 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Change https://go.dev/cl/585175 mentions this issue: |
All builders are now running on LUCI. Updates golang/go#65398 Change-Id: If2b0703ba0b6defd90d89c42895345eea30fd8cf Reviewed-on: https://go-review.googlesource.com/c/build/+/585175 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Proposal Details
@gopherbot, please add label new-builder
The text was updated successfully, but these errors were encountered: