Skip to content

x/website: unclosed tag causes formating issues in the FAQ page #65381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pellared opened this issue Jan 30, 2024 · 7 comments
Closed

x/website: unclosed tag causes formating issues in the FAQ page #65381

pellared opened this issue Jan 30, 2024 · 7 comments
Assignees
@thepudds
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website
Milestone
Unreleased

Comments

@pellared
Copy link
Contributor

pellared commented Jan 30, 2024 •
edited
Loading

What is the URL of the page with the issue?

https://go.dev/doc/faq#Do_Go_programs_link_with_Cpp_programs

What is your user agent?

Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36

Screenshot

image

What did you do?

Open https://go.dev/doc/faq#Do_Go_programs_link_with_Cpp_programs

What did you see happen?

The formatting (font) is broken after (gollvmTinyGo.

What did you expect to see?

Proper content. I guess the bug is visible after https://github.com/golang/website/commit/8bd7371ff7a9292aabc156833cd41f7f246b2796.\

I think that the content of https://github.com/golang/website/blob/master/_content/doc/faq.html is OK, but "website" fails to render it correctly.
@gopherbot gopherbot added this to the Unreleased milestone Jan 30, 2024
@mauri870 mauri870 changed the title x/pkgsite: FAQ is not properly formatted x/website: FAQ is not properly formatted Jan 30, 2024
@mauri870 mauri870 added NeedsFix The path to resolution is known, but the work has not been done. and removed pkgsite labels Jan 30, 2024
@mauri870 mauri870 self-assigned this Jan 30, 2024
@mauri870 mauri870 mentioned this issue Jan 30, 2024
Closed
@mauri870
Copy link
Member

mauri870 commented Jan 30, 2024 •
edited
Loading

Turns out it is just an unclosed code tag. Thanks for reporting it.

@mauri870 mauri870 changed the title x/website: FAQ is not properly formatted x/website: unclosed tag causes formating issues in the FAQ page Jan 30, 2024
@thepudds
Copy link
Contributor

I had noticed this and sent https://go.dev/cl/559501 a short while ago.

@mauri870
Copy link
Member

mauri870 commented Jan 30, 2024 •
edited
Loading

@thepudds Thanks for pointing it out, I wasn't aware of that. Can you please add some people from golang/tools-team as reviewers as well as a Fixes golang/go#65381 at the bottom of your commit message? Thanks

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/559501 mentions this issue: doc/faq: fix formatting problems due to missing angle bracket

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/559536 mentions this issue: doc: fix unclosed code tag in FAQ

@mauri870
Copy link
Member

@thepudds I'll close my CL in favor of yours, thanks for looking into it.

@mauri870 mauri870 assigned thepudds and unassigned mauri870 Jan 30, 2024
@thepudds
Copy link
Contributor

Hi @mauri870, thanks for looking at this too. I had noticed it and reported it on the earlier CL 559501, and Eli had replied there saying he would give it a review.

@gabyhelp gabyhelp mentioned this issue Dec 8, 2024
Closed
@golang golang locked and limited conversation to collaborators Jan 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thepudds thepudds

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. website
Projects
None yet
Milestone
Unreleased
Development

Successfully merging a pull request may close this issue.

doc: fix unclosed code tag in FAQ mauri870/website
4 participants
@pellared @gopherbot @mauri870 @thepudds