Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: TestIssue51759 consistently failing on gotip-darwin-amd64_10.15 LUCI builder [1.21 backport] #65380

Closed
gopherbot opened this issue Jan 30, 2024 · 2 comments
Closed

crypto/x509: TestIssue51759 consistently failing on gotip-darwin-amd64_10.15 LUCI builder [1.21 backport] #65380

gopherbot opened this issue Jan 30, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21.7

Comments

@gopherbot
Copy link

@prattmic requested issue #64677 to be considered for backport to the next 1.21 minor release.

@gopherbot Please backport to 1.20 and 1.21. This test failure applies on those release branches as well.
@gopherbot gopherbot added CherryPickCandidate Used during the release process for point releases Security Testing An issue that has been verified to require only test changes, not just a test failure. labels Jan 30, 2024
@gopherbot gopherbot mentioned this issue Jan 30, 2024
Closed
@dmitshur dmitshur removed the Security label Jan 30, 2024
@gopherbot gopherbot added this to the Go1.21.7 milestone Jan 30, 2024
@gopherbot
Copy link
Author

Change https://go.dev/cl/559517 mentions this issue: [release-branch.go1.21] crypto/x509: properly gate test on macos version

@mknyszek mknyszek added the CherryPickApproved Used during the release process for point releases label Jan 31, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jan 31, 2024
@gopherbot
Copy link
Author

Closed by merging 3960318 to release-branch.go1.21.

gopherbot pushed a commit that referenced this issue Jan 31, 2024
@rolandshoemaker @gopherbot
[release-branch.go1.21] crypto/x509: properly gate test on macos version
3960318 
Fixes the gating of TestIssue51759 by shelling out to sw_vers to check
what version of macOS we are on.

For #64677
Fixes #65380

Change-Id: I5eef4fa39e5449e7b2aa73864625c3abf002aef8
Reviewed-on: https://go-review.googlesource.com/c/go/+/549195
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit 400e24a)
Reviewed-on: https://go-review.googlesource.com/c/go/+/559517
Auto-Submit: Michael Pratt <mpratt@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.21.7
Development

No branches or pull requests
3 participants
@mknyszek @dmitshur @gopherbot